[DLCov] Move DebugLoc coverage macro to llvm-config.h #137787

SLTozer · 2025-04-29T11:00:13Z

This patch follows the reversion of #107279, which caused errors by including llvm/Config/config.h in a public header. In order to reapply that patch, this PR moves the definition of the config option to the llvm-config.h header instead, so that it can be used publicly. This patch also adds LLVM_ as a prefix to the define, since it is now in a public header.

jryans

Looks good to me, thanks! 😄

rscottmanley

LGTM. Thanks for fixing this!

llvm-ci · 2025-04-30T09:40:08Z

LLVM Buildbot has detected a new failure on builder fuchsia-x86_64-linux running on fuchsia-debian-64-us-central1-a-1 while building llvm,utils at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/14115

Here is the relevant piece of the build log for the reference

Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
[275/2499] Copying CXX header __algorithm/prev_permutation.h
[276/2499] Copying CXX header __bit/byteswap.h
[277/2499] Copying CXX header __atomic/support.h
[278/2499] Copying CXX header __algorithm/ranges_find_if.h
[279/2499] Copying CXX header __algorithm/partition_copy.h
[280/2499] Copying CXX header __algorithm/ranges_ends_with.h
[281/2499] Copying CXX header __bit/bit_cast.h
[282/2499] Building CXX object libc/src/errno/CMakeFiles/libc.src.errno.errno.dir/libc_errno.cpp.obj
[283/2499] Generating header uchar.h from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/runtimes/../libc/include/uchar.yaml
[284/2499] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj
FAILED: libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj 
/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-yw1damtv/./bin/clang++ --target=riscv32-unknown-elf -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc -isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-yw1damtv/include/riscv32-unknown-unknown-elf --target=riscv32-unknown-elf -march=rv32imafc -mabi=ilp32f -Wno-atomic-alignment "-Dvfprintf(stream, format, vlist)=vprintf(format, vlist)" "-Dfprintf(stream, format, ...)=printf(format)" -D_LIBCPP_PRINT=1 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -ffunction-sections -fdata-sections -ffile-prefix-map=/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-yw1damtv/runtimes/runtimes-riscv32-unknown-elf-bins=../../../../llvm-project -ffile-prefix-map=/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/= -no-canonical-prefixes -Os -DNDEBUG --target=riscv32-unknown-elf -DLIBC_QSORT_IMPL=LIBC_QSORT_HEAP_SORT -DLIBC_ADD_NULL_CHECKS "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES)" -fpie -ffreestanding -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -DLIBC_COPT_PUBLIC_PACKAGING -MD -MT libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj -MF libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj.d -o libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj -c /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/strstr.cpp
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/strstr.cpp:13:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/inline_strstr.h:15:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/string_utils.h:22:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/inline_bzero.h:15:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/inline_memset.h:14:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/utils.h:15:
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:43:13: error: unknown type name 'uint8_t'
   43 | LIBC_INLINE uint8_t
      |             ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:44:48: error: use of undeclared identifier 'uint8_t'
   44 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint8_t>(uint8_t v) {
      |                                                ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:44:48: error: use of undeclared identifier 'uint8_t'
   44 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint8_t>(uint8_t v) {
      |                                                ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:44:57: error: unknown type name 'uint8_t'
   44 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint8_t>(uint8_t v) {
      |                                                         ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:49:13: error: unknown type name 'uint8_t'
   49 | LIBC_INLINE uint8_t
      |             ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:50:51: error: use of undeclared identifier 'uint8_t'
   50 | Endian<__ORDER_LITTLE_ENDIAN__>::to_little_endian<uint8_t>(uint8_t v) {
      |                                                   ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:50:51: error: use of undeclared identifier 'uint8_t'
   50 | Endian<__ORDER_LITTLE_ENDIAN__>::to_little_endian<uint8_t>(uint8_t v) {
      |                                                   ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:50:60: error: unknown type name 'uint8_t'
   50 | Endian<__ORDER_LITTLE_ENDIAN__>::to_little_endian<uint8_t>(uint8_t v) {
      |                                                            ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:55:13: error: unknown type name 'uint16_t'
   55 | LIBC_INLINE uint16_t
      |             ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:56:48: error: use of undeclared identifier 'uint16_t'
   56 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint16_t>(uint16_t v) {
      |                                                ^~~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:56:48: error: use of undeclared identifier 'uint16_t'
Step 6 (build) failure: build (failure)
...
[275/2499] Copying CXX header __algorithm/prev_permutation.h
[276/2499] Copying CXX header __bit/byteswap.h
[277/2499] Copying CXX header __atomic/support.h
[278/2499] Copying CXX header __algorithm/ranges_find_if.h
[279/2499] Copying CXX header __algorithm/partition_copy.h
[280/2499] Copying CXX header __algorithm/ranges_ends_with.h
[281/2499] Copying CXX header __bit/bit_cast.h
[282/2499] Building CXX object libc/src/errno/CMakeFiles/libc.src.errno.errno.dir/libc_errno.cpp.obj
[283/2499] Generating header uchar.h from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/runtimes/../libc/include/uchar.yaml
[284/2499] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj
FAILED: libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj 
/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-yw1damtv/./bin/clang++ --target=riscv32-unknown-elf -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc -isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-yw1damtv/include/riscv32-unknown-unknown-elf --target=riscv32-unknown-elf -march=rv32imafc -mabi=ilp32f -Wno-atomic-alignment "-Dvfprintf(stream, format, vlist)=vprintf(format, vlist)" "-Dfprintf(stream, format, ...)=printf(format)" -D_LIBCPP_PRINT=1 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -ffunction-sections -fdata-sections -ffile-prefix-map=/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-yw1damtv/runtimes/runtimes-riscv32-unknown-elf-bins=../../../../llvm-project -ffile-prefix-map=/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/= -no-canonical-prefixes -Os -DNDEBUG --target=riscv32-unknown-elf -DLIBC_QSORT_IMPL=LIBC_QSORT_HEAP_SORT -DLIBC_ADD_NULL_CHECKS "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES)" -fpie -ffreestanding -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -DLIBC_COPT_PUBLIC_PACKAGING -MD -MT libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj -MF libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj.d -o libc/src/string/CMakeFiles/libc.src.string.strstr.dir/strstr.cpp.obj -c /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/strstr.cpp
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/strstr.cpp:13:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/inline_strstr.h:15:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/string_utils.h:22:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/inline_bzero.h:15:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/inline_memset.h:14:
In file included from /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/string/memory_utils/utils.h:15:
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:43:13: error: unknown type name 'uint8_t'
   43 | LIBC_INLINE uint8_t
      |             ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:44:48: error: use of undeclared identifier 'uint8_t'
   44 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint8_t>(uint8_t v) {
      |                                                ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:44:48: error: use of undeclared identifier 'uint8_t'
   44 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint8_t>(uint8_t v) {
      |                                                ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:44:57: error: unknown type name 'uint8_t'
   44 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint8_t>(uint8_t v) {
      |                                                         ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:49:13: error: unknown type name 'uint8_t'
   49 | LIBC_INLINE uint8_t
      |             ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:50:51: error: use of undeclared identifier 'uint8_t'
   50 | Endian<__ORDER_LITTLE_ENDIAN__>::to_little_endian<uint8_t>(uint8_t v) {
      |                                                   ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:50:51: error: use of undeclared identifier 'uint8_t'
   50 | Endian<__ORDER_LITTLE_ENDIAN__>::to_little_endian<uint8_t>(uint8_t v) {
      |                                                   ^~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:50:60: error: unknown type name 'uint8_t'
   50 | Endian<__ORDER_LITTLE_ENDIAN__>::to_little_endian<uint8_t>(uint8_t v) {
      |                                                            ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:55:13: error: unknown type name 'uint16_t'
   55 | LIBC_INLINE uint16_t
      |             ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:56:48: error: use of undeclared identifier 'uint16_t'
   56 | Endian<__ORDER_LITTLE_ENDIAN__>::to_big_endian<uint16_t>(uint16_t v) {
      |                                                ^~~~~~~~
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/src/__support/endian_internal.h:56:48: error: use of undeclared identifier 'uint16_t'

llvm-ci · 2025-04-30T18:51:28Z

LLVM Buildbot has detected a new failure on builder lld-x86_64-win running on as-worker-93 while building llvm,utils at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2817

Here is the relevant piece of the build log for the reference

Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/90/95' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe-LLVM-Unit-12344-90-95.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=95 GTEST_SHARD_INDEX=90 C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe
--

Script:
--
C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe --gtest_filter=ProgramEnvTest.CreateProcessLongPath
--
C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(160): error: Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(163): error: fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied



C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:160
Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:163
fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied




********************

This has been defined in #137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (#137787).

llvm-ci · 2025-05-04T05:53:42Z

LLVM Buildbot has detected a new failure on builder clang-arm64-windows-msvc running on linaro-armv8-windows-msvc-04 while building llvm,utils at step 3 "clean-build-dir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/5529

Here is the relevant piece of the build log for the reference

Step 3 (clean-build-dir) failure: Delete failed. (failure)
Step 5 (build-unified-tree) failure: build (failure)
...
366.224 [1795/10/3456] Building CXX object lib/ExecutionEngine/Orc/Shared/CMakeFiles/LLVMOrcShared.dir/SymbolStringPool.cpp.obj
366.230 [1794/10/3457] Building CXX object lib/ExecutionEngine/Orc/Shared/CMakeFiles/LLVMOrcShared.dir/SimpleRemoteEPCUtils.cpp.obj
366.412 [1793/10/3458] Linking CXX static library lib\LLVMOrcShared.lib
366.589 [1792/10/3459] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/DefaultHostBootstrapValues.cpp.obj
366.759 [1791/10/3460] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/JITLoaderGDB.cpp.obj
366.765 [1790/10/3461] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/JITLoaderVTune.cpp.obj
366.797 [1789/10/3462] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/JITLoaderPerf.cpp.obj
367.080 [1788/10/3463] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/RegisterEHFrames.cpp.obj
367.143 [1787/10/3464] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/OrcRTBootstrap.cpp.obj
367.171 [1786/10/3465] Linking CXX executable bin\clang.exe
FAILED: bin/clang.exe 
C:\WINDOWS\system32\cmd.exe /C "cd . && C:\Users\tcwg\scoop\apps\cmake\3.30.1\bin\cmake.exe -E vs_link_exe --intdir=tools\clang\tools\driver\CMakeFiles\clang.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\Users\tcwg\scoop\apps\llvm-arm64\current\bin\lld-link.exe /nologo @CMakeFiles\clang.rsp  /out:bin\clang.exe /implib:lib\clang.lib /pdb:bin\clang.pdb /version:0.0 /machine:ARM64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console && C:\WINDOWS\system32\cmd.exe /C "cd /D C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\build\tools\clang\tools\driver && C:\Users\tcwg\scoop\apps\cmake\3.30.1\bin\cmake.exe -E copy C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/build/bin/clang.exe C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/build/./bin/clang++.exe && cd /D C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\build\tools\clang\tools\driver && C:\Users\tcwg\scoop\apps\cmake\3.30.1\bin\cmake.exe -E copy C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/build/bin/clang.exe C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/build/./bin/clang-cl.exe && cd /D C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\build\tools\clang\tools\driver && C:\Users\tcwg\scoop\apps\cmake\3.30.1\bin\cmake.exe -E copy C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/build/bin/clang.exe C:/Users/tcwg/llvm-worker/clang-arm64-windows-msvc/build/./bin/clang-cpp.exe""
LINK: command "C:\Users\tcwg\scoop\apps\llvm-arm64\current\bin\lld-link.exe /nologo @CMakeFiles\clang.rsp /out:bin\clang.exe /implib:lib\clang.lib /pdb:bin\clang.pdb /version:0.0 /machine:ARM64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console /MANIFEST:EMBED,ID=1" failed (exit code 1) with the following output:
lld-link: error: failed to write output 'bin\clang.exe': permission denied

367.364 [1786/9/3466] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/SimpleExecutorDylibManager.cpp.obj
367.376 [1786/8/3467] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/ExecutorSharedMemoryMapperService.cpp.obj
367.396 [1786/7/3468] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/TargetExecutionUtils.cpp.obj
367.404 [1786/6/3469] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/SimpleExecutorMemoryManager.cpp.obj
367.822 [1786/5/3470] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/SimpleRemoteEPCServer.cpp.obj
367.823 [1786/4/3471] Building CXX object lib/ExecutionEngine/RuntimeDyld/CMakeFiles/LLVMRuntimeDyld.dir/RTDyldMemoryManager.cpp.obj
367.826 [1786/3/3472] Building CXX object lib/ExecutionEngine/Orc/TargetProcess/CMakeFiles/LLVMOrcTargetProcess.dir/UnwindInfoManager.cpp.obj
367.829 [1786/2/3473] Building CXX object lib/ExecutionEngine/RuntimeDyld/CMakeFiles/LLVMRuntimeDyld.dir/JITSymbol.cpp.obj
367.920 [1786/1/3474] Linking CXX executable bin\lld.exe
ninja: build stopped: subcommand failed.

This patch follows the reversion of llvm#107279, which caused errors by including `llvm/Config/config.h` in a public header. In order to reapply that patch, this PR moves the definition of the config option to the `llvm-config.h` header instead, so that it can be used publicly. This patch also adds `LLVM_` as a prefix to the define, since it is now in a public header.

This has been defined in llvm#137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (llvm#137787).

This patch follows the reversion of llvm#107279, which caused errors by including `llvm/Config/config.h` in a public header. In order to reapply that patch, this PR moves the definition of the config option to the `llvm-config.h` header instead, so that it can be used publicly. This patch also adds `LLVM_` as a prefix to the define, since it is now in a public header.

This has been defined in llvm#137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (llvm#137787).

[DLCov] Move DebugLoc coverage macro to llvm-config.h

2b08a7e

SLTozer requested a review from rscottmanley April 29, 2025 11:00

SLTozer self-assigned this Apr 29, 2025

SLTozer requested review from aaronmondal, keith and rupprecht as code owners April 29, 2025 11:00

llvmbot added cmake Build system in general and CMake in particular bazel "Peripheral" support tier build system: utils/bazel labels Apr 29, 2025

SLTozer requested review from aeubanks, jmorse, jryans and metaflow April 29, 2025 11:01

jryans approved these changes Apr 29, 2025

View reviewed changes

rscottmanley approved these changes Apr 29, 2025

View reviewed changes

SLTozer merged commit 3e52350 into llvm:main Apr 30, 2025
14 checks passed

chapuni added a commit that referenced this pull request May 1, 2025

[bazel] Turn on LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING

c588224

This has been defined in #137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (#137787).

IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025

[bazel] Turn on LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING

7df8ea2

This has been defined in llvm#137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (llvm#137787).

GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025

[bazel] Turn on LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING

b7607c3

This has been defined in llvm#137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (llvm#137787).

SLTozer mentioned this pull request Jun 17, 2025

[build] Fixed LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING handling. #144391

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DLCov] Move DebugLoc coverage macro to llvm-config.h #137787

[DLCov] Move DebugLoc coverage macro to llvm-config.h #137787

Uh oh!

SLTozer commented Apr 29, 2025

Uh oh!

jryans left a comment

Uh oh!

rscottmanley left a comment

Uh oh!

Uh oh!

llvm-ci commented Apr 30, 2025

Uh oh!

llvm-ci commented Apr 30, 2025

Uh oh!

llvm-ci commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[DLCov] Move DebugLoc coverage macro to llvm-config.h #137787

[DLCov] Move DebugLoc coverage macro to llvm-config.h #137787

Uh oh!

Conversation

SLTozer commented Apr 29, 2025

Uh oh!

jryans left a comment

Choose a reason for hiding this comment

Uh oh!

rscottmanley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

llvm-ci commented Apr 30, 2025

Uh oh!

llvm-ci commented Apr 30, 2025

Uh oh!

llvm-ci commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants