Skip to content

Emit nested unused enum types with -fno-eliminate-unused-debug-types #137818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

Emit nested unused enum types with -fno-eliminate-unused-debug-types #137818

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c5885d
fix emiision of nested unused enum types with -fno-eliminate-unused-d…
ykhatav Apr 29, 2025
e01ac20
reuse CollectRecordNestedType()
ykhatav May 2, 2025
9322f19
Apply clang-format
ykhatav May 2, 2025
c8df3c2
Make the emission of nested enums Similar to nested structs/classes/u…
ykhatav May 5, 2025
a0a0360
add name tag for struct
ykhatav May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/lib/CodeGen/CGDebugInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,7 +1987,8 @@ void CGDebugInfo::CollectRecordFields(

// Bump field number for next field.
++fieldNo;
} else if (CGM.getCodeGenOpts().EmitCodeView) {
} else if (CGM.getCodeGenOpts().hasMaybeUnusedDebugInfo() ||
CGM.getCodeGenOpts().EmitCodeView) {
// Debug info for nested types is included in the member list only for
// CodeView.
if (const auto *nestedType = dyn_cast<TypeDecl>(I)) {
Expand Down
30 changes: 30 additions & 0 deletions clang/test/CodeGen/unused_nested_enump.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// RUN: %clang_cc1 -debug-info-kind=unused-types -emit-llvm -o - %s | FileCheck %s
// RUN: %clang_cc1 -debug-info-kind=limited -emit-llvm -o - %s | FileCheck --check-prefix=NOUNUSEDTYPE %s

struct Type {
enum { Unused };
int value = 0;
};
int main() {
Type t;
return t.value;
}

// CHECK: ![[ENUM_MEMBER:[0-9]+]] = !DICompositeType(tag: DW_TAG_enumeration_type
// CHECK-SAME: scope: ![[STRUCT:[0-9]+]]
// CHECK-SAME: elements: ![[ELEMENTS:[0-9]+]]

// CHECK: ![[STRUCT]] = distinct !DICompositeType(tag: DW_TAG_structure_type
// CHECK-SAME: elements: ![[STRUCT_ELEMENTS:[0-9]+]]

// CHECK: ![[STRUCT_ELEMENTS]] = !{![[ENUM_MEMBER:[0-9]+]], ![[VALUE_MEMBER:[0-9]+]]}

// CHECK: ![[VALUE_MEMBER]] = !DIDerivedType(tag: DW_TAG_member
// CHECK-SAME: name: "value"
// CHECK-SAME: scope: ![[STRUCT]]

// CHECK: ![[ELEMENTS]] = !{![[ENUMERATOR:[0-9]+]]}
// CHECK: ![[ENUMERATOR]] = !DIEnumerator(name: "Unused", value: 0


// NOUNUSEDTYPE-NOT: !DIEnumerator(name: "Unused"