Skip to content

Conversation

@paschalis-mpeis
Copy link
Member

@paschalis-mpeis paschalis-mpeis commented Apr 29, 2025

Disabling this test on AArch64, until a consistent workaround is in place. See this comment of:

This would help unblock our buildbot (currently internal, but with plans of adding it to LLVM).

@llvmbot
Copy link
Member

llvmbot commented Apr 29, 2025

@llvm/pr-subscribers-bolt

Author: Paschalis Mpeis (paschalis-mpeis)

Changes

Disabling this test on AArch64, until a consistent workaround is in place. See this comment of:

  • #135867

Full diff: https://github.com/llvm/llvm-project/pull/137831.diff

1 Files Affected:

  • (modified) bolt/test/X86/callcont-fallthru.s (+2)
diff --git a/bolt/test/X86/callcont-fallthru.s b/bolt/test/X86/callcont-fallthru.s
index ee72d8f62e032..329cc9530bd68 100644
--- a/bolt/test/X86/callcont-fallthru.s
+++ b/bolt/test/X86/callcont-fallthru.s
@@ -1,6 +1,8 @@
 ## Ensures that a call continuation fallthrough count is set when using
 ## pre-aggregated perf data.
 
+# REQUIRES: x86_64-linux
+
 # RUN: %clang %cflags -fpic -shared -xc /dev/null -o %t.so
 ## Link against a DSO to ensure PLT entries.
 # RUN: %clangxx %cxxflags %s %t.so -o %t -Wl,-q -nostdlib

@paschalis-mpeis
Copy link
Member Author

(continuing discussion to this PR)

Quoting @yota9 from #135867 comment:

@paschalis-mpeis Indeed, you're right. Let's wait about @aaupov decision then, it LGTM

Great, thank you! @aaupov, are you happy hitting the green button here?

I've added a note to make sure we follow-up after #138232:

# TODO: Remove once llvm-nm supports --synthetic (#138232)

@paschalis-mpeis
Copy link
Member Author

Closed in favor of:

Next steps to re-enable tests will be after #138232.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants