Skip to content

[PPC][NFC] Remove duplicate processor feature from pwr9/10/11 and future #137903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

[PPC][NFC] Remove duplicate processor feature from pwr9/10/11 and future #137903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions llvm/lib/Target/PowerPC/PPC.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,7 @@ def ProcessorFeatures {
FeatureP9Vector,
FeaturePPCPreRASched,
FeaturePPCPostRASched,
FeatureISA3_0,
FeaturePredictableSelectIsExpensive
FeatureISA3_0
Copy link
Contributor

@jroelofs jroelofs Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a bit of a bigger refactor than you're looking to do here, but the AArch64 backend is a much better model for this: ISA features, and Tune features are separated out into parallel lists.

Copy link
Member Author

@mshockwave mshockwave Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, RISCV is doing that as well. Though I believe doing such separation for PPC is out of the scope of this patch.

];

// Some features are unique to Power9 and there is no reason to assume
Expand Down