Skip to content

Removed redundant assert and condition in APInt::SetBits #138038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2025
Merged

Removed redundant assert and condition in APInt::SetBits #138038

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b1749f1
removed redundant assert and condition in APInt::SetBits
liamsemeria Apr 30, 2025
85ccb4e
reinserted assert for lowBits in APInt::SetBits
liamsemeria May 1, 2025
e9097c7
removed redundant check for lowBits in APInt::SetBits
liamsemeria May 2, 2025
5da6a5f
Merge branch 'llvm:main' into SetBitsChanges
liamsemeria May 5, 2025
b36a066
removed unneeded lowBits assert in APInt::SetBits
liamsemeria May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions llvm/include/llvm/ADT/APInt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,11 +1366,10 @@ class [[nodiscard]] APInt {
/// This function handles case when \p loBit <= \p hiBit.
void setBits(unsigned loBit, unsigned hiBit) {
assert(hiBit <= BitWidth && "hiBit out of range");
assert(loBit <= BitWidth && "loBit out of range");
assert(loBit <= hiBit && "loBit greater than hiBit");
if (loBit == hiBit)
return;
if (loBit < APINT_BITS_PER_WORD && hiBit <= APINT_BITS_PER_WORD) {
if (hiBit <= APINT_BITS_PER_WORD) {
Copy link
Contributor

@jayfoad jayfoad May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the redundant assert on line 1369?

Copy link
Contributor Author

@liamsemeria liamsemeria May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did but I thought it was causing some windows test to fail when I pushed the change so I reverted it. I think the assert could still be helpful in some cases even though it's redundant.

uint64_t mask = WORDTYPE_MAX >> (APINT_BITS_PER_WORD - (hiBit - loBit));
mask <<= loBit;
if (isSingleWord())
Expand Down