[LLVM][Cygwin] Remove special case for CXX extensions on Cygwin. #138328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer necessary, and results in an inconvenient define of `i386` on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h. Signed-off-by: Jeremy Drake <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…m#138328) This is no longer necessary, and results in an inconvenient define of `i386` on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h. Signed-off-by: Jeremy Drake <[email protected]>
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…m#138328) This is no longer necessary, and results in an inconvenient define of `i386` on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h. Signed-off-by: Jeremy Drake <[email protected]>
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 14, 2025
…m#138328) This is no longer necessary, and results in an inconvenient define of `i386` on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h. Signed-off-by: Jeremy Drake <[email protected]>
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 15, 2025
…m#138328) This is no longer necessary, and results in an inconvenient define of `i386` on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h. Signed-off-by: Jeremy Drake <[email protected]>
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Jul 17, 2025
…m#138328) This is no longer necessary, and results in an inconvenient define of `i386` on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h. Signed-off-by: Jeremy Drake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer necessary, and results in an inconvenient define of
i386on i386 Cygwin targets which breaks compiling llvm/include/llvm/ExecutionEngine/JITLink/i386.h.