-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Register assembly printer passes #138348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register assembly printer passes #138348
Changes from 2 commits
e288df6
aa52b73
2df45ce
f86e7ac
0affae1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # RUN: llc -mtriple=riscv32 -verify-machineinstrs -start-before=riscv-expand-pseudo -simplify-mir -o /dev/null -pass-remarks-analysis=asm-printer %s 2>&1 | FileCheck %s | ||
| # RUN: llc -mtriple=riscv32 -verify-machineinstrs -start-before=riscv-asm-printer -simplify-mir -o /dev/null -pass-remarks-analysis=asm-printer %s 2>&1 | FileCheck %s | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this was passing I didn't review too closely, but all of these tests are passing for the wrong reasons:
Problem is So here we can substitute Further, this test fails on qualifying this (without changing the pipeline) with All in all I'm not sure if we should try to fix this; this issue is already fixed in the NPM path and no tests reference asm-printer like this. |
||
| --- | ||
| name: instrs | ||
| tracksRegLiveness: true | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the corresponding argument in the constructor