Skip to content

[AMDGPU] Use Reg32Types for move-immediate patterns #138422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

[AMDGPU] Use Reg32Types for move-immediate patterns #138422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions llvm/lib/Target/AMDGPU/SIInstructions.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2270,16 +2270,18 @@ def : GCNPat <

// FIXME: Remove VGPRImm. Should be inferrable from register bank.

foreach vt = [i32, p3, p5, p6, p2] in {
def : GCNPat <
(VGPRImm<(vt imm)>:$imm),
(V_MOV_B32_e32 imm:$imm)
>;
foreach vt = Reg32Types.types in {
if !and(!not(vt.isVector), !not(vt.isFP)) then {
Copy link
Contributor

@arsenm arsenm May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should have a more direct way to specify integer or pointer

def : GCNPat <
(VGPRImm<(vt imm)>:$imm),
(V_MOV_B32_e32 imm:$imm)
>;

def : GCNPat <
(vt imm:$imm),
(S_MOV_B32 imm:$imm)
>;
def : GCNPat <
(vt imm:$imm),
(S_MOV_B32 imm:$imm)
>;
}
}

// FIXME: The register bank of the frame index should depend on the
Expand Down
Loading