[WebAssembly] Remove an unused using decl (NFC) #138432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "using" decl seems to be unused since it was first introduced in: commit a8e1135 Author: Heejin Ahn <[email protected]> Date: Thu Jan 9 22:36:10 2025 -0800
Member
|
@llvm/pr-subscribers-backend-webassembly Author: Kazu Hirata (kazutakahirata) ChangesThe "using" decl seems to be unused since it was first introduced in: commit a8e1135 Full diff: https://github.com/llvm/llvm-project/pull/138432.diff 1 Files Affected:
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
index 873d2c59dc18c..cc96d7b2293f4 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
@@ -401,7 +401,6 @@ using WebAssembly::WasmEnableEH;
using WebAssembly::WasmEnableEmEH;
using WebAssembly::WasmEnableEmSjLj;
using WebAssembly::WasmEnableSjLj;
-using WebAssembly::WasmUseLegacyEH;
static void basicCheckForEHAndSjLj(TargetMachine *TM) {
|
nikic
approved these changes
May 4, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
The "using" decl seems to be unused since it was first introduced in: commit a8e1135 Author: Heejin Ahn <[email protected]> Date: Thu Jan 9 22:36:10 2025 -0800
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
The "using" decl seems to be unused since it was first introduced in: commit a8e1135 Author: Heejin Ahn <[email protected]> Date: Thu Jan 9 22:36:10 2025 -0800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "using" decl seems to be unused since it was first introduced in:
commit a8e1135
Author: Heejin Ahn [email protected]
Date: Thu Jan 9 22:36:10 2025 -0800