Skip to content

[flang][Evaluate] Fix AsGenericExpr for Relational #138455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

[flang][Evaluate] Fix AsGenericExpr for Relational #138455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
053e565
[flang][Evaluate] Fix AsGenericExpr for Relational
kparzysz May 4, 2025
a9daa4c
Add deleted empty line back
kparzysz May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions flang/include/flang/Evaluate/tools.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ template <typename A> common::IfNoLvalue<Expr<ResultType<A>>, A> AsExpr(A &&x) {
return Expr<ResultType<A>>{std::move(x)};
}

template <typename T, typename U = typename Relational<T>::Result>
Expr<U> AsExpr(Relational<T> &&x) {
// The variant in Expr<Type<TypeCategory::Logical, KIND>> only contains
// Relational<SomeType>, not other Relational<T>s. Wrap the Relational<T>
// in Relational<SomeType> before creating Expr<>.
return Expr<U>(Relational<SomeType>{std::move(x)});
}

template <typename T> Expr<T> AsExpr(Expr<T> &&x) {
static_assert(IsSpecificIntrinsicType<T>);
return std::move(x);
Expand Down