Skip to content

[clang] Remove unused local variables (NFC) #138468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

[clang] Remove unused local variables (NFC) #138468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConstraintManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,6 @@ class SMTConstraintManager : public clang::ento::SimpleConstraintManager {

// Construct the logical AND of all the constraints
if (I != IE) {
std::vector<llvm::SMTExprRef> ASTs;

llvm::SMTExprRef Constraint = I++->second;
while (I != IE) {
Constraint = Solver->mkAnd(Constraint, I++->second);
Expand Down
1 change: 0 additions & 1 deletion clang/lib/Sema/SemaPPC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI,
CallExpr *TheCall) {
ASTContext &Context = getASTContext();
bool IsTarget64Bit = TI.getTypeWidth(TI.getIntPtrType()) == 64;
llvm::APSInt Result;

if (isPPC_64Builtin(BuiltinID) && !IsTarget64Bit)
return Diag(TheCall->getBeginLoc(), diag::err_64_bit_builtin_32_bit_tgt)
Expand Down
2 changes: 0 additions & 2 deletions clang/lib/Sema/SemaTemplateDeduction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6605,8 +6605,6 @@ bool Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs(
llvm_unreachable("Unexpected Result");
}

SmallVector<TemplateArgument, 4> DeducedArgs(Deduced.begin(), Deduced.end());

TemplateDeductionResult TDK;
runWithSufficientStackSpace(Info.getLocation(), [&] {
TDK = ::FinishTemplateArgumentDeduction(
Expand Down
2 changes: 0 additions & 2 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,6 @@ std::optional<bool> isUnsafePtr(const QualType T, bool IsArcEnabled) {
std::optional<bool> isGetterOfSafePtr(const CXXMethodDecl *M) {
assert(M);

std::optional<RetainTypeChecker> RTC;

if (isa<CXXMethodDecl>(M)) {
const CXXRecordDecl *calleeMethodsClass = M->getParent();
auto className = safeGetName(calleeMethodsClass);
Expand Down
2 changes: 0 additions & 2 deletions clang/lib/StaticAnalyzer/Core/BugReporter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3377,8 +3377,6 @@ PathSensitiveBugReporter::generateDiagnosticForConsumerMap(
BugReport *exampleReport,
ArrayRef<std::unique_ptr<PathDiagnosticConsumer>> consumers,
ArrayRef<BugReport *> bugReports) {
std::vector<BasicBugReport *> BasicBugReports;
std::vector<PathSensitiveBugReport *> PathSensitiveBugReports;
if (isa<BasicBugReport>(exampleReport))
return BugReporter::generateDiagnosticForConsumerMap(exampleReport,
consumers, bugReports);
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ static bool isWithinConstantOverflowBounds(llvm::APSInt I) {
assert(!AT.isUnsigned() &&
"This only works with signed integers!");

llvm::APSInt Max = AT.getMaxValue() / AT.getValue(4), Min = -Max;
llvm::APSInt Max = AT.getMaxValue() / AT.getValue(4);
return (I <= Max) && (I >= -Max);
}

Expand Down
1 change: 0 additions & 1 deletion clang/unittests/Tooling/CompilationDatabaseTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,6 @@ TEST(ParseFixedCompilationDatabase, HandlesArgv0) {
Database->getCompileCommands("source");
ASSERT_EQ(1ul, Result.size());
ASSERT_EQ(".", Result[0].Directory);
std::vector<std::string> Expected;
ASSERT_THAT(Result[0].CommandLine,
ElementsAre(EndsWith("clang-tool"), "source"));
EXPECT_EQ(2, Argc);
Expand Down