Skip to content

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented May 5, 2025

It doesn't like this extended enum idiom, so make the code worse.

Fixes #125549

It doesn't like this extended enum idiom, so make the code worse.

Fixes #125549
@arsenm arsenm marked this pull request as ready for review May 5, 2025 13:17
Copy link
Contributor Author

arsenm commented May 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented May 5, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

It doesn't like this extended enum idiom, so make the code worse.

Fixes #125549


Full diff: https://github.com/llvm/llvm-project/pull/138529.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp (+2-1)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
index 236c373e70250..b6023b4f3fbcf 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
@@ -2971,7 +2971,8 @@ SDValue AMDGPUTargetLowering::lowerFEXP10Unsafe(SDValue X, const SDLoc &SL,
                                                 SelectionDAG &DAG,
                                                 SDNodeFlags Flags) const {
   const EVT VT = X.getValueType();
-  const unsigned Exp2Op = VT == MVT::f32 ? AMDGPUISD::EXP : ISD::FEXP2;
+  const unsigned Exp2Op = VT == MVT::f32 ? static_cast<unsigned>(AMDGPUISD::EXP)
+                                         : static_cast<unsigned>(ISD::FEXP2);
 
   if (VT != MVT::f32 || !needsDenormHandlingF32(DAG, X, Flags)) {
     // exp2(x * 0x1.a92000p+1f) * exp2(x * 0x1.4f0978p-11f);

@arsenm arsenm merged commit 003e501 into main May 5, 2025
13 of 15 checks passed
@arsenm arsenm deleted the users/arsenm/issue125549/fix-enum-warning branch May 5, 2025 14:26
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-Wenum-compare reported in llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp

4 participants