Skip to content

[mlir][spirv] Add support for RelaxedPrecision in function arguments #138685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

[mlir][spirv] Add support for RelaxedPrecision in function arguments #138685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c909198
[mlir][spirv] Add support for RelaxedPrecision in function arguments
IgWod-IMG May 1, 2025
eaa3926
Address feedback
IgWod-IMG May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,21 @@ LogicalResult spirv::Deserializer::setFunctionArgAttrs(
foundDecorationAttr = spirv::DecorationAttr::get(context, decoration);
break;
}

if (decAttr.getName() == getSymbolDecoration(stringifyDecoration(
spirv::Decoration::RelaxedPrecision))) {
// TODO: Current implementation supports only one decoration per function
// parameter so RelaxedPrecision cannot be applied at the same time as,
// for example, Aliased/Restrict/etc. This should be relaxed to allow any
// combination of decoration allowed by the spec to be supported.
if (foundDecorationAttr)
Copy link
Member

@antiagainst antiagainst May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the old behavior which restricts it to only support one decoration per function parameter; we should relax this. But fine to do it later.

Copy link
Contributor Author

@IgWod-IMG IgWod-IMG May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to know, I was wondering whether I missed something. I will leave the PR as it is, but I added a TODO, so it can be addressed in the future.

return emitError(unknownLoc, "already found a decoration for function "
"argument with result <id> ")
<< argID;

foundDecorationAttr = spirv::DecorationAttr::get(
context, spirv::Decoration::RelaxedPrecision);
}
}

if (!foundDecorationAttr)
Expand Down
9 changes: 9 additions & 0 deletions mlir/test/Target/SPIRV/decorations.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,12 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [CacheControlsINTEL], [SP
spirv.Return
}
}

// -----

spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
// CHECK: spirv.func @relaxed_precision_arg({{%.*}}: !spirv.ptr<f32, Function> {spirv.decoration = #spirv.decoration<RelaxedPrecision>}) "None" attributes {relaxed_precision} {
spirv.func @relaxed_precision_arg(%arg0: !spirv.ptr<f32, Function> {spirv.decoration = #spirv.decoration<RelaxedPrecision>}) -> () "None" attributes {relaxed_precision} {
Copy link
Member

@antiagainst antiagainst May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing // CHECK line here?

Copy link
Contributor Author

@IgWod-IMG IgWod-IMG May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's indeed missing. Fixed now.

spirv.Return
}
}