Skip to content

[DWARFLinkerParallel] Change more cases of compare_exchange_weak to compare_exchange_strong #138692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

[DWARFLinkerParallel] Change more cases of compare_exchange_weak to compare_exchange_strong #138692

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01c4f45
[DWARFLinkerParallel] Change more cases of compare_exchange_weak to c…
mstorsjo May 6, 2025
baf827f
Restore compare_exchange_weak in two cases where it should be ok
mstorsjo May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/lib/DWARFLinker/Parallel/ArrayList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ template <typename T, size_t ItemsGroupSize = 512> class ArrayList {
if (!CurGroup->Next)
allocateNewGroup(CurGroup->Next);

LastGroup.compare_exchange_weak(CurGroup, CurGroup->Next);
LastGroup.compare_exchange_strong(CurGroup, CurGroup->Next);
} while (true);

// Store item into the current group.
Expand Down Expand Up @@ -137,15 +137,15 @@ template <typename T, size_t ItemsGroupSize = 512> class ArrayList {
NewGroup->Next = nullptr;

// Try to replace current group with allocated one.
if (AtomicGroup.compare_exchange_weak(CurGroup, NewGroup))
if (AtomicGroup.compare_exchange_strong(CurGroup, NewGroup))
return true;

// Put allocated group as last group.
while (CurGroup) {
ItemsGroup *NextGroup = CurGroup->Next;

if (!NextGroup) {
if (CurGroup->Next.compare_exchange_weak(NextGroup, NewGroup))
if (CurGroup->Next.compare_exchange_strong(NextGroup, NewGroup))
break;
}

Expand Down