[AMDGPU] Fix VTList for BUFFER_LOAD and DENORM_MODE #138704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bugs that would be caught by verifyTargetNode in llvm#119709.
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Jay Foad (jayfoad) ChangesThis fixes bugs that would be caught by verifyTargetNode in #119709. Full diff: https://github.com/llvm/llvm-project/pull/138704.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index d7f1f1c651d68..b08b6b46fc52c 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -8703,7 +8703,7 @@ SDValue SITargetLowering::lowerSBuffer(EVT VT, SDLoc DL, SDValue Rsrc,
LoadVT = MVT::getVectorVT(LoadVT.getScalarType(), 4);
}
- SDVTList VTList = DAG.getVTList({LoadVT, MVT::Glue});
+ SDVTList VTList = DAG.getVTList({LoadVT, MVT::Other});
// Use the alignment to ensure that the required offsets will fit into the
// immediate offsets.
@@ -11184,9 +11184,10 @@ SDValue SITargetLowering::LowerFDIV32(SDValue Op, SelectionDAG &DAG) const {
const SDValue DisableDenormValue = getSPDenormModeValue(
FP_DENORM_FLUSH_IN_FLUSH_OUT, DAG, Info, Subtarget);
+ SDVTList BindParamVTs = DAG.getVTList(MVT::Other, MVT::Glue);
DisableDenorm =
- DAG.getNode(AMDGPUISD::DENORM_MODE, SL, MVT::Other, Fma4.getValue(1),
- DisableDenormValue, Fma4.getValue(2))
+ DAG.getNode(AMDGPUISD::DENORM_MODE, SL, BindParamVTs,
+ Fma4.getValue(1), DisableDenormValue, Fma4.getValue(2))
.getNode();
} else {
assert(HasDynamicDenormals == (bool)SavedDenormMode);
|
arsenm
approved these changes
May 6, 2025
jayfoad
commented
May 6, 2025
| const SDValue DisableDenormValue = getSPDenormModeValue( | ||
| FP_DENORM_FLUSH_IN_FLUSH_OUT, DAG, Info, Subtarget); | ||
|
|
||
| SDVTList BindParamVTs = DAG.getVTList(MVT::Other, MVT::Glue); |
Contributor
Author
There was a problem hiding this comment.
I don't know what the name BindParamVTs means - I just copied it from the code above.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
This fixes bugs that would be caught by verifyTargetNode in llvm#119709.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugs that would be caught by verifyTargetNode in #119709.