Skip to content

[Clang] Add warnings when mixing different charN_t types #138708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2025
Merged

[Clang] Add warnings when mixing different charN_t types #138708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c23bf23
[Clang] Add warnings when mixing different charN_t types
cor3ntin May 6, 2025
513b292
format
cor3ntin May 6, 2025
e31e747
Silence warnings in libc++
cor3ntin May 8, 2025
2df2d48
try to fix the libc++ build
cor3ntin May 8, 2025
5e092e7
Use -Wcharacter-conversion, add it to -Wconversion, make it a feature…
cor3ntin May 10, 2025
8e39dc9
Don't warn if one side of the comparison can be evaluated to a code p…
cor3ntin May 10, 2025
c299893
libc++ 03 fixes
cor3ntin May 10, 2025
9a17333
I guess I don't know my ascii tables...
cor3ntin May 11, 2025
52367ec
revert some uneeded changes to libc++ tests
cor3ntin May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
// equal(Iter1 first1, Iter1 last1, Iter2 first2, Iter2 last2);

// We test the cartesian product, so we sometimes compare differently signed types
// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-sign-compare -Wno-implicit-unicode-conversion
// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-sign-compare
// ADDITIONAL_COMPILE_FLAGS(clang-21): -Wno-implicit-unicode-conversion
Copy link
Member

@EricWF EricWF May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens in clang-22?


// MSVC warning C4242: 'argument': conversion from 'int' to 'const _Ty', possible loss of data
// MSVC warning C4244: 'argument': conversion from 'wchar_t' to 'const _Ty', possible loss of data
// MSVC warning C4389: '==': signed/unsigned mismatch
Expand Down
3 changes: 2 additions & 1 deletion libcxx/test/std/algorithms/alg.nonmodifying/alg.find/find.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
//===----------------------------------------------------------------------===//

// ADDITIONAL_COMPILE_FLAGS(gcc): -Wno-bool-compare
// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-sign-compare -Wno-implicit-unicode-conversion
// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-sign-compare
// ADDITIONAL_COMPILE_FLAGS(clang-21): -Wno-implicit-unicode-conversion
// MSVC warning C4245: conversion from 'int' to 'wchar_t', signed/unsigned mismatch
// MSVC warning C4305: truncation from 'int' to 'bool'
// MSVC warning C4310: cast truncates constant value
Expand Down