Skip to content

llvm-jitlink: Fix bug in target address computation. #138794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: users/pcc/spr/main.llvm-jitlink-fix-bug-in-target-address-computation
Choose a base branch
from
Open

llvm-jitlink: Fix bug in target address computation. #138794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
439d16a
[𝘀𝗽𝗿] initial version
pcc May 7, 2025
77ca3ff
Format
pcc May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/tools/llvm-jitlink/llvm-jitlink-elf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ Error registerELFGraphInfo(Session &S, LinkGraph &G) {
else
FileInfo.SectionInfos[Sec.getName()] = {
ArrayRef<char>(FirstSym->getBlock().getContent().data(), SecSize),
SecAddr.getValue(), FirstSym->getTargetFlags()};
(SecAddr - FirstSym->getOffset()).getValue(),
Copy link
Contributor

@lhames lhames May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting this here, it seems like it'd be tidier to define SecAddr like this on line 183:

auto SecAddr = FirstSym->getAddress() - FirstSym->getOffset();

Unless you've already tried that and hit other issues I'm happy to go ahead and make that change.

FirstSym->getTargetFlags()};
}

return Error::success();
Expand Down