Skip to content

[lldb] Fixed TestProcessModificationIdOnExpr to work on both x86 and x64 architectures #138941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

[lldb] Fixed TestProcessModificationIdOnExpr to work on both x86 and x64 architectures #138941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions lldb/test/Shell/Expr/TestProcessModificationIdOnExpr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Tests that ProcessModID.m_memory_id is not bumped when evaluating expressions without side effects.

// REQUIRES: target-windows && target-x86
// Due to different implementations exact numbers (m_stop_id) are different on different OSs. So we lock this test to specific platform (Windows). It is limited to x86 because on x86, running get()
// REQUIRES: target-windows && (target-x86 || target-x86_64)
// Due to different implementations exact numbers (m_stop_id) are different on different OSs. So we lock this test to specific platform (Windows). It is limited to x86/x64 because on x86/x64, running get()
// requires that we write the return address to the stack, this does not happen on AArch64.

// RUN: %build %s -o %t
Expand All @@ -11,10 +11,13 @@
// RUN: -o "process status -d" \
// RUN: -o "expr x.i != 42" \
// RUN: -o "process status -d" \
// RUN: -o "process status -d" \
// RUN: -o "expr x.get()" \
// RUN: -o "process status -d" \
// RUN: -o "process status -d" \
// RUN: -o "expr x.i = 10" \
// RUN: -o "process status -d" \
// RUN: -o "process status -d" \
// RUN: -o "continue" \
// RUN: -o "process status -d" \
// RUN: -o "exit" | FileCheck %s -dump-input=fail
Expand All @@ -36,34 +39,49 @@ int main() {
}

// CHECK-LABEL: process status -d
// CHECK: m_stop_id: 2
// CHECK: m_memory_id: 0
// CHECK: m_stop_id: [[#STOP_ID:]]
// CHECK: m_memory_id: [[#MEMORY_ID:]]

// CHECK-LABEL: expr x.i != 42
// IDs are not changed when executing simple expressions

// CHECK-LABEL: process status -d
// CHECK: m_stop_id: 2
// CHECK: m_memory_id: 0
// CHECK: m_stop_id: [[#STOP_ID]]
// CHECK: m_memory_id: [[#MEMORY_ID]]

// CHECK-LABEL: process status -d
// Remember new values
// CHECK: m_stop_id: [[#STOP_ID:]]
// CHECK: m_memory_id: [[#MEMORY_ID:]]

// CHECK-LABEL: expr x.get()
// Expression causes ID to be bumped because LLDB has to execute function and in doing
// so must write the return address to the stack.

// CHECK-LABEL: process status -d
// CHECK: m_stop_id: 3
// CHECK: m_memory_id: 1
// CHECK-NOT: m_stop_id: [[#STOP_ID]]
// CHECK-NOT: m_memory_id: [[#MEMORY_ID]]

// CHECK-LABEL: process status -d
// Remember new values
// CHECK: m_stop_id: [[#STOP_ID:]]
// CHECK: m_memory_id: [[#MEMORY_ID:]]

// CHECK-LABEL: expr x.i = 10
// Expression causes MemoryID to be bumped because LLDB writes to non-cache memory

// CHECK-LABEL: process status -d
// CHECK: m_stop_id: 3
// CHECK: m_memory_id: 2
// CHECK: m_stop_id: [[#STOP_ID]]
// CHECK-NOT: m_memory_id: [[#MEMORY_ID]]

// CHECK-LABEL: process status -d
// Remember new values
// CHECK: m_stop_id: [[#STOP_ID:]]
// CHECK: m_memory_id: [[#MEMORY_ID:]]

// CHECK-LABEL: continue
// Continue causes StopID to be bumped because process is resumed

// CHECK-LABEL: process status -d
// CHECK: m_stop_id: 4
// CHECK: m_memory_id: 2
// CHECK-NOT: m_stop_id: [[#STOP_ID]]
// CHECK: m_memory_id: [[#MEMORY_ID]]
Loading