Skip to content

[llvm][docs] Improve usage note on stacked PRs #138949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

[llvm][docs] Improve usage note on stacked PRs #138949

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d359bbd
[llvm][docs] Improve usage note on stacked PRs
paschalis-mpeis May 7, 2025
8997d0f
Addressing reviewers
paschalis-mpeis May 7, 2025
b262556
Addressing reviewers (2)
paschalis-mpeis May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions llvm/docs/GitHub.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,16 +288,15 @@ Your options are as follows:
in ``llvm/llvm-project``.

.. note::
When not using user branches, GitHub will not display proper diffs for
When using the second approach, GitHub will not display proper diffs for
subsequent PRs in a stack. Instead, it will show a combined diff that
includes all commits from earlier PRs.

As described in the first option above, in such cases it is the PR author’s
responsibility to clearly indicate which commits are relevant to the
current PR. For example: “The first N commits are from the base PR.”
As described above, it is the PR author’s responsibility to clearly indicate
which commits are relevant to the current PR.
For example: “The first N commits are from the base PR.”

You can avoid this issue by using user branches directly in the
``llvm/llvm-project`` repository.
You can avoid this issue by using the first or the third approach.


Using Graphite for stacked Pull Requests
Expand Down
Loading