-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[HLSL] Add resource constructor with implicit binding for global resources #138976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d5685ec
[HLSL] Implement DXILResourceBindingAnalysis
hekota d8a4a3f
Rename DXILResourceBindingsInfo to DXILResourceBindingInfo
hekota d79900c
Merge branch 'main' of https://github.com/llvm/llvm-project into reso…
hekota c718763
Add wrapper pass
hekota 9a70f06
update signature
hekota bca1bf3
code review feedback - rename flags, remove unnecessary functions, do…
hekota f58e2d5
[HLSL] Implementation of DXILResourceImplicitBinding pass
hekota b65d3bc
fix bug & update tests
hekota 075e27e
Merge branch 'main' of https://github.com/llvm/llvm-project into reso…
hekota 2f0aba1
Remove extra new line
hekota 79c2e7b
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota e9747e5
Merge branch 'main' of https://github.com/llvm/llvm-project into reso…
hekota da838a9
Merge branch 'users/hekota/pr137258-resource-binding-analysis' of htt…
hekota dfce6ce
[HLSL] Add resource constructor with implicit binding for global reso…
hekota 8a27708
code review feedback - use std::optional, renames
hekota bc93994
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota 8142713
Merge branch 'users/hekota/pr138043-implicit-binding-pass' of https:/…
hekota 4a3e4c5
revert changes to StructuredBuffers-methods-ps.hlsl
hekota fb3d516
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota 2ff496b
code review feedback - update comment, rename param
hekota e4369aa
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota cecd1e4
simplify constructor tests
hekota cef2c3e
rename vars
hekota File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ void SecondEntry() {} | |
|
||
// Verify the constructor is alwaysinline | ||
// NOINLINE: ; Function Attrs: {{.*}}alwaysinline | ||
// NOINLINE-NEXT: define linkonce_odr void @_ZN4hlsl8RWBufferIfEC2Ev({{.*}} [[CtorAttr:\#[0-9]+]] | ||
// NOINLINE-NEXT: define linkonce_odr void @_ZN4hlsl8RWBufferIfEC2Ejijj({{.*}} [[CtorAttr:\#[0-9]+]] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is changing the |
||
|
||
// NOINLINE: ; Function Attrs: {{.*}}alwaysinline | ||
// NOINLINE-NEXT: define internal void @_GLOBAL__sub_I_GlobalConstructorLib.hlsl() [[InitAttr:\#[0-9]+]] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.