Skip to content

[NFC][ubsan_minimal] Clang-format a file #139000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025
Merged

[NFC][ubsan_minimal] Clang-format a file #139000

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3d32f4
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka May 8, 2025
88c5b58
[𝘀𝗽𝗿] initial version
vitalybuka May 8, 2025
9ffd039
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka May 8, 2025
55f3a0a
another test
vitalybuka May 8, 2025
8af71bf
rebase
vitalybuka May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
#include "sanitizer_common/sanitizer_atomic.h"

#include <stdlib.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>

#ifdef KERNEL_USE
extern "C" void ubsan_message(const char *msg);
static void message(const char *msg) { ubsan_message(msg); }
#else
static void message(const char *msg) {
(void)write(2, msg, strlen(msg));
}
static void message(const char *msg) { (void)write(2, msg, strlen(msg)); }
#endif

static const int kMaxCallerPcs = 20;
Expand Down Expand Up @@ -62,16 +60,18 @@ SANITIZER_INTERFACE_WEAK_DEF(void, __ubsan_report_error, const char *kind,
uintptr_t p;
for (unsigned i = 0; i < sz; ++i) {
p = __sanitizer::atomic_load_relaxed(&caller_pcs[i]);
if (p == 0) break; // Concurrent update.
if (p == 0)
break; // Concurrent update.
if (p == caller)
return;
}
if (p == 0) continue; // FIXME: yield?
if (p == 0)
continue; // FIXME: yield?
}

if (!__sanitizer::atomic_compare_exchange_strong(
&caller_pcs_sz, &sz, sz + 1, __sanitizer::memory_order_seq_cst))
continue; // Concurrent update! Try again from the start.
continue; // Concurrent update! Try again from the start.

if (sz == kMaxCallerPcs) {
message("ubsan: too many errors\n");
Expand Down