[docs][mlgo] Document MLModelRunner
#139205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Some initial comments, mostly LGTM.
| - ``InteractiveModelRunner``. This is intended for training scenarios where the | ||
| training algorithm drives compilation. This model runner has no special | ||
| dependencies, and relies on I/O pipes to communicate with a separate process | ||
| - presumably a python training algorithm. We do not envision using this in a |
Contributor
There was a problem hiding this comment.
Extra hyphen here? I'm assuming sphinx would format that weirdly.
Member
Author
There was a problem hiding this comment.
wdym, where would a hypen go?
Contributor
There was a problem hiding this comment.
It seems to be used to delineate list elements here (MLModelRunner implementations), but the sentence here is continuous.
boomanaiden154
approved these changes
May 9, 2025
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM. After addressing my last comment.
| - ``InteractiveModelRunner``. This is intended for training scenarios where the | ||
| training algorithm drives compilation. This model runner has no special | ||
| dependencies, and relies on I/O pipes to communicate with a separate process | ||
| - presumably a python training algorithm. We do not envision using this in a |
Contributor
There was a problem hiding this comment.
It seems to be used to delineate list elements here (MLModelRunner implementations), but the sentence here is continuous.
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/8241 Here is the relevant piece of the build log for the reference |
mtrofin
added a commit
to mtrofin/llvm-project
that referenced
this pull request
May 11, 2025
Missed the last feedback in llvm#139205
mtrofin
added a commit
that referenced
this pull request
May 11, 2025
Collaborator
|
After this was pointed to in the LLVM weekly, I thought to have a read of this document. |
kbeyls
reviewed
May 14, 2025
Comment on lines
+63
to
+65
| The main types in LLVM are: | ||
| - ``MLModelRunner`` - an abstraction for the decision making mechanism | ||
| - ``TensorSpec`` which describes a tensor. |
Collaborator
There was a problem hiding this comment.
Apologies for the late comment. I just noticed that this "bullet list" doesn't get formatted as a bullet list at https://llvm.org/docs/MLGO.html. Maybe this needs a newline before the start of the bullet point list?
Member
Author
It's currently there under hidden topics, we'll move it out in a bit - wanted to finish the current batch of docs first. |
mtrofin
added a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.