[OpenMP][test] Properly check for NULL #139364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only 2 `openmp` testsuite failures remain on Solaris/amd64. They are due the same issue: the tests in question assume `NULL` pointers to be printed as `(nil)` while the rest of the testsuite uses `[[NULL]]` for that. This patch changes them to follow suit. Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
llvmbot
added
openmp:libomp
Collaborator
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only 2
openmptestsuite failures remain on Solaris/amd64. They are due the same issue: the tests in question assumeNULLpointers to be printed as(nil)while the rest of the testsuite uses[[NULL]]for that.This patch changes them to follow suit.
Tested on
amd64-pc-solaris2.11andx86_64-pc-linux-gnu.