Skip to content

[lldb] Simplify string comparisons (NFC) #139394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 1 commit into from
May 10, 2025
Merged

[lldb] Simplify string comparisons (NFC) #139394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ class InstructionLLVMC : public lldb_private::Instruction {
return std::make_pair(ret, osi);
}
case 'x':
if (!str.compare("0")) {
if (str == "0") {
is_hex = true;
str.push_back(*osi);
} else {
Expand Down
4 changes: 2 additions & 2 deletions lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ void ASTResultSynthesizer::TransformTopLevelDecl(Decl *D) {
} else if (!m_top_level) {
if (ObjCMethodDecl *method_decl = dyn_cast<ObjCMethodDecl>(D)) {
if (m_ast_context &&
!method_decl->getSelector().getAsString().compare("$__lldb_expr:")) {
method_decl->getSelector().getAsString() == "$__lldb_expr:") {
RecordPersistentTypes(method_decl);
SynthesizeObjCMethodResult(method_decl);
}
} else if (FunctionDecl *function_decl = dyn_cast<FunctionDecl>(D)) {
// When completing user input the body of the function may be a nullptr.
if (m_ast_context && function_decl->hasBody() &&
!function_decl->getNameInfo().getAsString().compare("$__lldb_expr")) {
function_decl->getNameInfo().getAsString() == "$__lldb_expr") {
RecordPersistentTypes(function_decl);
SynthesizeFunctionResult(function_decl);
}
Expand Down
4 changes: 2 additions & 2 deletions lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,9 @@ size_t ELFLinuxPrStatus::GetSize(const lldb_private::ArchSpec &arch) {
if (arch.IsMIPS()) {
std::string abi = arch.GetTargetABI();
assert(!abi.empty() && "ABI is not set");
if (!abi.compare("n64"))
if (abi == "n64")
return sizeof(ELFLinuxPrStatus);
else if (!abi.compare("o32"))
else if (abi == "o32")
return mips_linux_pr_status_size_o32;
// N32 ABI
return mips_linux_pr_status_size_n32;
Expand Down
Loading