-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[SelectionDAGBuilder] Use address width when lowering ptrtoaddr #139423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: users/arichardson/spr/main.selectiondagbuilder-use-address-width-when-lowering-ptrtoaddr
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3980,8 +3980,16 @@ void SelectionDAGBuilder::visitSIToFP(const User &I) { | |
} | ||
|
||
void SelectionDAGBuilder::visitPtrToAddr(const User &I) { | ||
// FIXME: this is not correct for pointers with addr width != pointer width | ||
visitPtrToInt(I); | ||
const auto &TLI = DAG.getTargetLoweringInfo(); | ||
const DataLayout &DL = DAG.getDataLayout(); | ||
// ptrtoaddr is equivalent to a truncate of ptrtoint to address/index width | ||
auto Op0 = I.getOperand(0); | ||
SDValue N = getValue(Op0); | ||
// By definition the type of the ptrtoaddr must be equal to the address type. | ||
assert(I.getType() == DL.getAddressType(Op0->getType())); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't need to assert things enforced by the verifier |
||
EVT AddrVT = TLI.getValueType(DL, I.getType()); | ||
N = DAG.getNode(ISD::TRUNCATE, getCurSDLoc(), AddrVT, N); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If these are the same type, why do you need the truncate? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While most targets will have them be the same, the Op0 type can be wider. This is the case e.g. for the AMD GPU buffer pointers. |
||
setValue(&I, N); | ||
} | ||
|
||
void SelectionDAGBuilder::visitPtrToInt(const User &I) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No auto