Skip to content

[Clang][Sema] Disable checking invalid template id in initializer of primary variable template std::format_kind with libstdc++ #139560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

[Clang][Sema] Disable checking invalid template id in initializer of primary variable template std::format_kind with libstdc++ #139560

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f514b59
Disable checking invalid template id in initializer of primary variab…
zwuis May 12, 2025
4069c64
Add a test, and check libstdc++ revision date in more detail
zwuis May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions clang/lib/Sema/SemaTemplate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4383,6 +4383,11 @@ Sema::CheckVarTemplateId(VarTemplateDecl *Template, SourceLocation TemplateLoc,
};

if (VarDecl *Var = Template->getTemplatedDecl();
// Skipping std::format_kind in libstdc++ is a hack for
// GH139067 / https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120190
!(Var->getName() == "format_kind" &&
Var->getDeclContext()->isStdNamespace() &&
PP.isMacroDefined("__GLIBCXX__")) &&
Copy link
Collaborator

@erichkeane erichkeane May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could find some sort of way to check the actual VERSION of the hack once they fix this, but it doesn't look like they have a fix in flight.

Copy link
Contributor

@cor3ntin cor3ntin May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clang you add something like // HACK workaround libstdc++ 14.x (2025-02) so it's easier to find?

ParsingInitForAutoVars.count(Var) &&
llvm::equal(
CTAI.CanonicalConverted,
Expand Down
Loading