Skip to content

[TableGen] Use std::string::find (NFC) #139681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

[TableGen] Use std::string::find (NFC) #139681

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92f0e76
[TableGen] Use std::string::find (NFC)
kazutakahirata May 13, 2025
73051b8
Address a comment.
kazutakahirata May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/lib/TableGen/Record.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1796,11 +1796,11 @@ const Init *TernOpInit::Fold(const Record *CurRec) const {
if (LHSs && MHSs && RHSs) {
std::string Val = RHSs->getValue().str();

StringRef::size_type found;
StringRef::size_type idx = 0;
std::string::size_type found;
std::string::size_type idx = 0;
while (true) {
found = StringRef(Val).find(LHSs->getValue(), idx);
if (found == StringRef::npos)
found = Val.find(LHSs->getValue(), idx);
if (found == std::string::npos)
break;
Val.replace(found, LHSs->getValue().size(), MHSs->getValue().str());
idx = found + MHSs->getValue().size();
Expand Down