-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[X86] IsElementEquivalent - add handling for ISD::BITCASTS from smaller vector elements #139741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
65bd124
b04822d
495673a
48aca61
c592ac2
5f7c9a6
fd1a5c9
d02bbbc
7762631
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1569,25 +1569,19 @@ define <2 x i64> @mul_v2i64_neg_17_65(<2 x i64> %a0) nounwind { | |
| } | ||
|
|
||
| define <2 x i64> @mul_v2i64_0_1(<2 x i64> %a0) nounwind { | ||
| ; X86-SSE2-LABEL: mul_v2i64_0_1: | ||
| ; X86-SSE2: # %bb.0: | ||
| ; X86-SSE2-NEXT: xorpd %xmm1, %xmm1 | ||
| ; X86-SSE2-NEXT: movsd {{.*#+}} xmm0 = xmm1[0],xmm0[1] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you just referring to the extra move?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, I mean
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm struggling to come up with a way DAG can handle this cleanly - these are v2i64 shuffles that the domain pass flipped later on, much later than the TwoAddr commutation fixes. Whats happened is the i686 targets are now able to see the v2i64 zero (legalised to v4i32 zero) and match as a v2i64 shuffle instead of falling back to a v2f64 bitcasted shuffle. Unless we can demonstrate that MOVSD/S isn't affected by domain crossing we don't have a good pass to fix this :(
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. to be clear, all that has happened is the i686 codegen now matches the x86_64 which has always had this int/fp domain behavior
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, I think 32-bit performance is not so important. |
||
| ; X86-SSE2-NEXT: retl | ||
| ; SSE2-LABEL: mul_v2i64_0_1: | ||
| ; SSE2: # %bb.0: | ||
| ; SSE2-NEXT: xorps %xmm1, %xmm1 | ||
| ; SSE2-NEXT: unpckhpd {{.*#+}} xmm1 = xmm1[1],xmm0[1] | ||
| ; SSE2-NEXT: movaps %xmm1, %xmm0 | ||
| ; SSE2-NEXT: ret{{[l|q]}} | ||
| ; | ||
| ; SSE4-LABEL: mul_v2i64_0_1: | ||
| ; SSE4: # %bb.0: | ||
| ; SSE4-NEXT: xorps %xmm1, %xmm1 | ||
| ; SSE4-NEXT: blendps {{.*#+}} xmm0 = xmm1[0,1],xmm0[2,3] | ||
| ; SSE4-NEXT: ret{{[l|q]}} | ||
| ; | ||
| ; X64-SSE2-LABEL: mul_v2i64_0_1: | ||
| ; X64-SSE2: # %bb.0: | ||
| ; X64-SSE2-NEXT: xorps %xmm1, %xmm1 | ||
| ; X64-SSE2-NEXT: unpckhpd {{.*#+}} xmm1 = xmm1[1],xmm0[1] | ||
| ; X64-SSE2-NEXT: movaps %xmm1, %xmm0 | ||
| ; X64-SSE2-NEXT: retq | ||
| ; | ||
| ; X64-AVX-LABEL: mul_v2i64_0_1: | ||
| ; X64-AVX: # %bb.0: | ||
| ; X64-AVX-NEXT: vxorps %xmm1, %xmm1, %xmm1 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.