Skip to content

[lldb] Reduce max-children-count default to readable size #139826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

[lldb] Reduce max-children-count default to readable size #139826

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52c587e
[lldb] Reduce max-children-count default to readable size
kastiglione May 9, 2025
84cfdf8
Test fixes
kastiglione May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Target/TargetProperties.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ let Definition = "target" in {
DefaultUnsignedValue<6>,
Desc<"The maximum number of zeroes to insert when displaying a very small float before falling back to scientific notation.">;
def MaxChildrenCount: Property<"max-children-count", "UInt64">,
DefaultUnsignedValue<256>,
DefaultUnsignedValue<24>,
Desc<"Maximum number of children to expand in any level of depth.">;
def MaxChildrenDepth: Property<"max-children-depth", "UInt64">,
DefaultUnsignedValue<0xFFFFFFFF>,
Expand Down
2 changes: 1 addition & 1 deletion ...-formatter/data-formatter-stl/generic/forward_list/TestDataFormatterGenericForwardList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def do_test(self, stdlib_type):
self.expect(
"settings show target.max-children-count",
matching=True,
substrs=["target.max-children-count (unsigned) = 256"],
substrs=["target.max-children-count (unsigned) = 24"],
)

self.expect(
Expand Down
1 change: 0 additions & 1 deletion ...ionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...es/data-formatter/data-formatter-stl/generic/multimap/TestDataFormatterGenericMultiMap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...es/data-formatter/data-formatter-stl/generic/multiset/TestDataFormatterGenericMultiSet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...ctionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion .../data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)
self.runCmd("settings set auto-one-line-summaries true", check=False)

# Execute the cleanup function during test case tear down.
Expand Down
1 change: 0 additions & 1 deletion ...ities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...nalities/data-formatter/data-formatter-stl/libcxx/string/TestDataFormatterLibcxxString.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

is_64_bit = self.process().GetAddressByteSize() == 8

Expand Down
1 change: 0 additions & 1 deletion ...data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
4 changes: 3 additions & 1 deletion ...ionalities/data-formatter/data-formatter-stl/libcxx/vbool/TestDataFormatterLibcxxVBool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)
self.runCmd("settings set target.max-children-count 24", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)

self.runCmd("settings set target.max-children-count 49", check=False)

self.expect(
"frame variable vBool",
substrs=[
Expand Down
1 change: 0 additions & 1 deletion ...nalities/data-formatter/data-formatter-stl/libcxx/vector/TestDataFormatterLibcxxVector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...ties/data-formatter/data-formatter-stl/libstdcpp/iterator/TestDataFormatterStdIterator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...unctionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...nalities/data-formatter/data-formatter-stl/libstdcpp/string/TestDataFormatterStdString.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...ionalities/data-formatter/data-formatter-stl/libstdcpp/vbool/TestDataFormatterStdVBool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
1 change: 0 additions & 1 deletion ...nalities/data-formatter/data-formatter-stl/libstdcpp/vector/TestDataFormatterStdVector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand Down
6 changes: 3 additions & 3 deletions lldb/test/API/functionalities/data-formatter/synthcapping/TestSyntheticCapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def cleanup():
self.runCmd("type summary clear", check=False)
self.runCmd("type filter clear", check=False)
self.runCmd("type synth clear", check=False)
self.runCmd("settings set target.max-children-count 256", check=False)
self.runCmd("settings set target.max-children-count 24", check=False)

# Execute the cleanup function during test case tear down.
self.addTearDownHook(cleanup)
Expand All @@ -68,10 +68,10 @@ def cleanup():
"r = 34",
],
)
# num_children() should be called with at most max_num_children=257
# num_children() should be called with at most max_num_children=25
# (target.max-children-count + 1)
self.expect(
"script fooSynthProvider.reset_max_num_children_max()", substrs=["257"]
"script fooSynthProvider.reset_max_num_children_max()", substrs=["25"]
)

# check that capping works
Expand Down
Loading