[Mips] When emit instruction, ignore JUMP_TABLE_DEBUG_INFO #139830
Conversation
|
|
||
| // This instruction is only used to note jump table debug info, we | ||
| // did not need to emit it. | ||
| if (I->getOpcode() == TargetOpcode::JUMP_TABLE_DEBUG_INFO) |
There was a problem hiding this comment.
Should it emit some debug info?
There was a problem hiding this comment.
OK, I would add it.
yingopq
force-pushed
the
Fix_bug_issue_134916
branch
from
2268229 to
ca5ea1b
Compare
|
|
||
| // This instruction is only used to note jump table debug info, we | ||
| // did not need to emit it. | ||
| if (I->getOpcode() == TargetOpcode::JUMP_TABLE_DEBUG_INFO) { |
There was a problem hiding this comment.
I mean emit a comment line into the asm output with some useful information.
|
This pseudo instruction is already skipped by the generic code in The reason it got to MipsAsmPrinter is because it was bundled with I don't think it is intentional. |
|
I think a better fix would be to add |
| @@ -0,0 +1,119 @@ | |||
| ; RUN: llc -mtriple=mipsel-windows-gnu < %s | FileCheck %s -check-prefix=MIPSEL | |||
There was a problem hiding this comment.
Should use an existing jumptable*.ll test and add the windows-gnu triple there
There was a problem hiding this comment.
The existing file named jumptable_labels.ll, I thought this file mainly focused on testing labels, so I choose to add a new file.
Since you think this is OK, I will add a -mtriple=mips-windows-gnu there.
Thanks!
There was a problem hiding this comment.
mips is under-maintained and I find many tests need refactoring. It's great to think about whether tests can be enhanced before adding a new one:) https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-too-little#i-dont-know-an-existing-test-can-be-enhanced
Good idea, thanks! |
yingopq
force-pushed
the
Fix_bug_issue_134916
branch
2 times, most recently
from
ff7287b to
873188e
Compare
yingopq
force-pushed
the
Fix_bug_issue_134916
branch
3 times, most recently
from
e021e15 to
f96fcca
Compare
|
@wzssyqa @s-barannikov Ping. |
1 similar comment
|
@wzssyqa @s-barannikov Ping. |
There was a problem hiding this comment.
The last part of the comment is misleading, otherwise LGTM.
There was a problem hiding this comment.
Thanks, I delete that part.
When -triple is windows, SelectionDAGLegalize process Legalizing br_jt, would generate ISD::JUMP_TABLE_DEBUG_INFO. Then Mips process emitInstruction, would think JUMP_TABLE_DEBUG_INFO is a pseudo instruction and generate an error `Pseudo opcode found in emitInstruction()`. This instruction `TargetOpcode::JUMP_TABLE_DEBUG_INFO` is only used to note jump table debug info, so we can ignore it when Mips emit instruction. Fix llvm#134916.
yingopq
force-pushed
the
Fix_bug_issue_134916
branch
from
f96fcca to
6ca09bc
Compare
5 participants
When -triple is windows, SelectionDAGLegalize process Legalizing br_jt, would generate ISD::JUMP_TABLE_DEBUG_INFO.
Then Mips process emitInstruction, would think JUMP_TABLE_DEBUG_INFO is a pseudo instruction and generate an error
Pseudo opcode found in emitInstruction().This instruction
TargetOpcode::JUMP_TABLE_DEBUG_INFOis only used to note jump table debug info, so we can ignore it when Mips emit instruction.Fix #134916.