Skip to content

[mlir] Use llvm::find_if (NFC) #139912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 1 commit into from
May 14, 2025
Merged

[mlir] Use llvm::find_if (NFC) #139912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,10 @@ void AffineDataCopyGeneration::runOnBlock(Block *block,
// moment; we do a check later and report an error with location info.

// Get to the first load, store, or for op (that is not a copy nest itself).
auto curBegin =
std::find_if(block->begin(), block->end(), [&](Operation &op) {
return isa<AffineLoadOp, AffineStoreOp, AffineForOp>(op) &&
copyNests.count(&op) == 0;
});
auto curBegin = llvm::find_if(*block, [&](Operation &op) {
return isa<AffineLoadOp, AffineStoreOp, AffineForOp>(op) &&
copyNests.count(&op) == 0;
});

// Create [begin, end) ranges.
auto it = curBegin;
Expand Down
4 changes: 2 additions & 2 deletions mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ LogicalResult SparseTensorEncodingAttr::verify(
return emitError() << "unexpected coordinate bitwidth: " << crdWidth;

// Verify every COO segment.
auto *it = std::find_if(lvlTypes.begin(), lvlTypes.end(), isSingletonLT);
auto *it = llvm::find_if(lvlTypes, isSingletonLT);
while (it != lvlTypes.end()) {
if (it == lvlTypes.begin() ||
!(it - 1)->isa<LevelFormat::Compressed, LevelFormat::LooseCompressed>())
Expand Down Expand Up @@ -829,7 +829,7 @@ LogicalResult SparseTensorEncodingAttr::verify(
}

// TODO: audit formats that actually are supported by backend.
if (auto it = std::find_if(lvlTypes.begin(), lvlTypes.end(), isNOutOfMLT);
if (auto it = llvm::find_if(lvlTypes, isNOutOfMLT);
it != std::end(lvlTypes)) {
if (it != lvlTypes.end() - 1)
return emitError() << "expected n_out_of_m to be the last level type";
Expand Down