Skip to content

Conversation

@ashermancinelli
Copy link
Contributor

@ashermancinelli ashermancinelli commented May 14, 2025

On some compilers the implicit copy constructor assignment operator was issuing a warning.

On some compilers the implicit copy constructor was issuing a
warning.
@ashermancinelli ashermancinelli self-assigned this May 14, 2025
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:semantics labels May 14, 2025
@llvmbot
Copy link
Member

llvmbot commented May 14, 2025

@llvm/pr-subscribers-flang-semantics

Author: Asher Mancinelli (ashermancinelli)

Changes

On some compilers the implicit copy constructor was issuing a warning.


Full diff: https://github.com/llvm/llvm-project/pull/139966.diff

1 Files Affected:

  • (modified) flang/include/flang/Semantics/symbol.h (+1)
diff --git a/flang/include/flang/Semantics/symbol.h b/flang/include/flang/Semantics/symbol.h
index 97c1e30631840..4cded64d170cd 100644
--- a/flang/include/flang/Semantics/symbol.h
+++ b/flang/include/flang/Semantics/symbol.h
@@ -600,6 +600,7 @@ class TypeParamDetails {
 public:
   TypeParamDetails() = default;
   TypeParamDetails(const TypeParamDetails &) = default;
+  TypeParamDetails &operator=(const TypeParamDetails &) = default;
   std::optional<common::TypeParamAttr> attr() const { return attr_; }
   TypeParamDetails &set_attr(common::TypeParamAttr);
   MaybeIntExpr &init() { return init_; }

@klausler
Copy link
Contributor

klausler commented May 14, 2025

On some compilers the implicit copy constructor was issuing a warning.

It's a copy assignment operator. Which compilers complain?

UPDATE: it was clang-17

@ashermancinelli ashermancinelli merged commit ed572aa into llvm:main May 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:semantics flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants