Skip to content

[StaticDataLayout][PGO]Implement reader and writer change for data access profiles #139997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 22, 2025
Merged

[StaticDataLayout][PGO]Implement reader and writer change for data access profiles #139997

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6cd7d8d
Add classes to construct and use data access profiles
mingmingl-llvm May 1, 2025
4727529
resolve review feedback
mingmingl-llvm May 5, 2025
80249bc
Apply suggestions from code review
mingmingl-llvm May 6, 2025
b69c993
resolve review feedback
mingmingl-llvm May 6, 2025
6fe9b48
run 'git merge main'
mingmingl-llvm May 6, 2025
df08094
resolve feedback
mingmingl-llvm May 6, 2025
6dd04e4
resolve comments
mingmingl-llvm May 13, 2025
4045c94
Support reading and writing data access profiles in memprof v4.
mingmingl-llvm May 15, 2025
f63fea6
run 'git merge main'
mingmingl-llvm May 16, 2025
c5d8fcf
resolve comments
mingmingl-llvm May 16, 2025
0fb3e6a
record data access profile payload length
mingmingl-llvm May 16, 2025
d3443c7
undo length record and check
mingmingl-llvm May 19, 2025
c9f1f2b
resolve review comments
mingmingl-llvm May 21, 2025
5d0e236
resolve comments
mingmingl-llvm May 22, 2025
b14f1e2
Test backward compatibility
mingmingl-llvm May 22, 2025
09eab64
fix typo
mingmingl-llvm May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions llvm/test/tools/llvm-profdata/memprof-yaml.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
; RUN: llvm-profdata show --memory %t/memprof-out.indexed > %t/memprof-out.yaml
; RUN: diff -b %t/memprof-in.yaml %t/memprof-out.yaml

; Merge text profile as v3 binary profile. Test that the merged v3 profile
; are identical to memprof-in-v3.ymal, and doesn't have callee guids or dap.
Copy link
Contributor

@teresajohnson teresajohnson May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ymal/yaml/

Copy link
Contributor Author

@mingmingl-llvm mingmingl-llvm May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

; RUN: llvm-profdata merge --memprof-version=3 %t/memprof-in.yaml -o %t/memprof-out-v3.indexed
; RUN: llvm-profdata show --memory %t/memprof-out-v3.indexed > %t/memprof-out-v3.yaml
; RUN: diff -b %t/memprof-out-v3.yaml %t/memprof-in-v3.yaml

; memprof-in-no-dap.yaml has empty data access profiles.
; RUN: llvm-profdata merge --memprof-version=4 %t/memprof-in-no-dap.yaml -o %t/memprof-out.indexed
; RUN: llvm-profdata show --memory %t/memprof-out.indexed > %t/memprof-out-no-dap.yaml
Expand Down Expand Up @@ -59,6 +65,35 @@ DataAccessProfiles:
- bar
KnownColdStrHashes: [ 999, 1001 ]
...
;--- memprof-in-v3.yaml
---
HeapProfileRecords:
- GUID: 0xdeadbeef12345678
AllocSites:
- Callstack:
- { Function: 0x1111111111111111, LineOffset: 11, Column: 10, IsInlineFrame: true }
- { Function: 0x2222222222222222, LineOffset: 22, Column: 20, IsInlineFrame: false }
MemInfoBlock:
AllocCount: 111
TotalSize: 222
TotalLifetime: 333
TotalLifetimeAccessDensity: 444
- Callstack:
- { Function: 0x3333333333333333, LineOffset: 33, Column: 30, IsInlineFrame: false }
- { Function: 0x4444444444444444, LineOffset: 44, Column: 40, IsInlineFrame: true }
MemInfoBlock:
AllocCount: 555
TotalSize: 666
TotalLifetime: 777
TotalLifetimeAccessDensity: 888
CallSites:
- Frames:
- { Function: 0x5555555555555555, LineOffset: 55, Column: 50, IsInlineFrame: true }
- { Function: 0x6666666666666666, LineOffset: 66, Column: 60, IsInlineFrame: false }
- Frames:
- { Function: 0x7777777777777777, LineOffset: 77, Column: 70, IsInlineFrame: true }
- { Function: 0x8888888888888888, LineOffset: 88, Column: 80, IsInlineFrame: false }
...
;--- memprof-in-no-dap.yaml
---
HeapProfileRecords:
Expand Down