Skip to content

[ARM] Remove kill flags in ReplaceConstByVPNOTs. #140082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
+25 −1
Merged

[ARM] Remove kill flags in ReplaceConstByVPNOTs. #140082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/lib/Target/ARM/MVETPAndVPTOptimisationsPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,6 +984,7 @@ bool MVETPAndVPTOptimisations::ReplaceConstByVPNOTs(MachineBasicBlock &MBB,
if (MRI->hasOneUse(GPR))
DeadInstructions.insert(MRI->getVRegDef(GPR));
}
MRI->clearKillFlags(LastVPTReg);
LLVM_DEBUG(dbgs() << "Adding VPNot: " << *VPNot << " to replace use at "
<< Instr);
VPR = NewVPR;
Expand Down
25 changes: 24 additions & 1 deletion llvm/test/CodeGen/Thumb2/mve-vpt-optimisations.mir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,5 +1042,28 @@ body: |
%5:mqpr = IMPLICIT_DEF
%6:mqpr = MVE_VORR %5:mqpr, %5:mqpr, 1, killed %4, $noreg, undef %6
tBX_RET 14 /* CC::al */, $noreg, implicit %5:mqpr

...
---
name: kill_flags_2
alignment: 4
body: |
bb.0:
; CHECK-LABEL: name: kill_flags_2
; CHECK: [[COPY:%[0-9]+]]:mqpr = COPY $q0
; CHECK-NEXT: [[t2MOVi:%[0-9]+]]:rgpr = t2MOVi 0, 14 /* CC::al */, $noreg, $noreg
; CHECK-NEXT: [[COPY1:%[0-9]+]]:vccr = COPY [[t2MOVi]]
; CHECK-NEXT: [[MVE_VHADDs8_:%[0-9]+]]:mqpr = MVE_VHADDs8 [[COPY]], [[COPY]], 1, [[COPY1]], $noreg, [[COPY]]
; CHECK-NEXT: [[MVE_VPNOT:%[0-9]+]]:vccr = MVE_VPNOT [[COPY1]], 0, $noreg, $noreg
; CHECK-NEXT: [[MVE_VSLIimm8_:%[0-9]+]]:mqpr = MVE_VSLIimm8 [[MVE_VHADDs8_]], [[COPY]], 0, 1, [[MVE_VPNOT]], $noreg
; CHECK-NEXT: $q0 = COPY [[MVE_VSLIimm8_]]
; CHECK-NEXT: tBX_RET 14 /* CC::al */, $noreg, implicit $q0
%0:mqpr = COPY $q0
%1:rgpr = t2MOVi 0, 14, $noreg, $noreg
%2:vccr = COPY %1:rgpr
%3:mqpr = MVE_VHADDs8 %0:mqpr, %0:mqpr, 1, killed %2:vccr, $noreg, %0:mqpr
%4:rgpr = t2MOVi16 65535, 14, $noreg
%5:vccr = COPY %4:rgpr
%6:mqpr = MVE_VSLIimm8 %3:mqpr, %0:mqpr, 0, 1, killed %5:vccr, $noreg
$q0 = COPY %6:mqpr
tBX_RET 14, $noreg, implicit $q0
...