Skip to content

[PowerPC][NFC] clean up if-else block in PPCRegisterInfo.cpp #140084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

[PowerPC][NFC] clean up if-else block in PPCRegisterInfo.cpp #140084

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed1ae34
[PowerPC][NFC] clean up if-else block in PPCRegisterInfo.cpp
lei137 May 15, 2025
e2bc995
move all if-else conditions into a switch stmt for spills
lei137 May 15, 2025
540af59
add default for switch
lei137 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 42 additions & 33 deletions llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,62 +1610,71 @@ PPCRegisterInfo::eliminateFrameIndex(MachineBasicBlock::iterator II,
// Get the instruction opcode.
unsigned OpC = MI.getOpcode();

if ((OpC == PPC::DYNAREAOFFSET || OpC == PPC::DYNAREAOFFSET8)) {
switch (OpC) {
Copy link
Contributor

@diggerlin diggerlin May 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no default for the switch , is there a compile warning or error for it ?

Copy link
Contributor Author

@lei137 lei137 May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, default handling is after the switch. Can add:

default: break;

default:
break;
case PPC::DYNAREAOFFSET:
case PPC::DYNAREAOFFSET8:
lowerDynamicAreaOffset(II);
// lowerDynamicAreaOffset erases II
return true;
case PPC::DYNALLOC:
case PPC::DYNALLOC8: {
// Special case for dynamic alloca.
if (FPSI && FrameIndex == FPSI) {
lowerDynamicAlloc(II); // lowerDynamicAlloc erases II
return true;
}
break;
}

// Special case for dynamic alloca.
if (FPSI && FrameIndex == FPSI &&
(OpC == PPC::DYNALLOC || OpC == PPC::DYNALLOC8)) {
lowerDynamicAlloc(II);
// lowerDynamicAlloc erases II
return true;
}

if (FPSI && FrameIndex == FPSI &&
(OpC == PPC::PREPARE_PROBED_ALLOCA_64 ||
OpC == PPC::PREPARE_PROBED_ALLOCA_32 ||
OpC == PPC::PREPARE_PROBED_ALLOCA_NEGSIZE_SAME_REG_64 ||
OpC == PPC::PREPARE_PROBED_ALLOCA_NEGSIZE_SAME_REG_32)) {
lowerPrepareProbedAlloca(II);
// lowerPrepareProbedAlloca erases II
return true;
case PPC::PREPARE_PROBED_ALLOCA_64:
case PPC::PREPARE_PROBED_ALLOCA_32:
case PPC::PREPARE_PROBED_ALLOCA_NEGSIZE_SAME_REG_64:
case PPC::PREPARE_PROBED_ALLOCA_NEGSIZE_SAME_REG_32: {
if (FPSI && FrameIndex == FPSI) {
lowerPrepareProbedAlloca(II); // lowerPrepareProbedAlloca erases II
return true;
}
break;
}

// Special case for pseudo-ops SPILL_CR and RESTORE_CR, etc.
if (OpC == PPC::SPILL_CR) {
case PPC::SPILL_CR:
// Special case for pseudo-ops SPILL_CR and RESTORE_CR, etc.
lowerCRSpilling(II, FrameIndex);
return true;
} else if (OpC == PPC::RESTORE_CR) {
case PPC::RESTORE_CR:
lowerCRRestore(II, FrameIndex);
return true;
} else if (OpC == PPC::SPILL_CRBIT) {
case PPC::SPILL_CRBIT:
lowerCRBitSpilling(II, FrameIndex);
return true;
} else if (OpC == PPC::RESTORE_CRBIT) {
case PPC::RESTORE_CRBIT:
lowerCRBitRestore(II, FrameIndex);
return true;
} else if (OpC == PPC::SPILL_ACC || OpC == PPC::SPILL_UACC) {
case PPC::SPILL_ACC:
case PPC::SPILL_UACC:
lowerACCSpilling(II, FrameIndex);
return true;
} else if (OpC == PPC::RESTORE_ACC || OpC == PPC::RESTORE_UACC) {
case PPC::RESTORE_ACC:
case PPC::RESTORE_UACC:
lowerACCRestore(II, FrameIndex);
return true;
} else if (OpC == PPC::STXVP && DisableAutoPairedVecSt) {
lowerOctWordSpilling(II, FrameIndex);
return true;
} else if (OpC == PPC::SPILL_WACC) {
case PPC::STXVP: {
if (DisableAutoPairedVecSt) {
lowerOctWordSpilling(II, FrameIndex);
return true;
}
break;
}
case PPC::SPILL_WACC:
lowerWACCSpilling(II, FrameIndex);
return true;
} else if (OpC == PPC::RESTORE_WACC) {
case PPC::RESTORE_WACC:
lowerWACCRestore(II, FrameIndex);
return true;
} else if (OpC == PPC::SPILL_QUADWORD) {
case PPC::SPILL_QUADWORD:
lowerQuadwordSpilling(II, FrameIndex);
return true;
} else if (OpC == PPC::RESTORE_QUADWORD) {
case PPC::RESTORE_QUADWORD:
lowerQuadwordRestore(II, FrameIndex);
return true;
}
Expand Down
Loading