Skip to content

[-Wunsafe-buffer-usage] Fix false warnings when const sized array is safely accessed (array [idx %const]) #140113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2025
Merged

[-Wunsafe-buffer-usage] Fix false warnings when const sized array is safely accessed (array [idx %const]) #140113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6d8a58
[-Wunsafe-buffer-usage] Fix false warnings when const array is safely…
May 15, 2025
334b062
Fixing the formatting issue and added tests.
May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion clang/lib/Analysis/UnsafeBufferUsage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,12 +600,27 @@ static bool isSafeArraySubscript(const ArraySubscriptExpr &Node,
} else if (const auto *BE = dyn_cast<BinaryOperator>(IndexExpr)) {
// For an integer expression `e` and an integer constant `n`, `e & n` and
// `n & e` are bounded by `n`:
if (BE->getOpcode() != BO_And)
if (BE->getOpcode() != BO_And && BE->getOpcode() != BO_Rem)
return false;

const Expr *LHS = BE->getLHS();
const Expr *RHS = BE->getRHS();

if(BE->getOpcode() == BO_Rem) {
// If n is a negative number, then n % const can be greater than const
if(!LHS->getType()->isUnsignedIntegerType()) {
return false;
}

if(!RHS->isValueDependent() && RHS->EvaluateAsInt(EVResult, Ctx)) {
llvm::APSInt result = EVResult.Val.getInt();
if (result.isNonNegative() && result.getLimitedValue() <= limit)
Copy link

Copilot AI May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment to explain the purpose and derivation of the 'limit' variable to enhance clarity on how it determines the safe boundary for remainder operations.

Copilot uses AI. Check for mistakes.
return true;
}

return false;
}

if ((!LHS->isValueDependent() &&
LHS->EvaluateAsInt(EVResult, Ctx)) || // case: `n & e`
(!RHS->isValueDependent() &&
Expand Down
10 changes: 9 additions & 1 deletion clang/test/SemaCXX/warn-unsafe-buffer-usage-array.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,15 @@ void constant_idx_safe0(unsigned idx) {
buffer[0] = 0;
}

int array[10]; // expected-warning {{'array' is an unsafe buffer that does not perform bounds checks}}
int array[10]; // expected-warning 2{{'array' is an unsafe buffer that does not perform bounds checks}}
Copy link

Copilot AI May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the update from a single expected warning to two is intentional and that the test comment clearly communicates the new warning count rationale.

Copilot uses AI. Check for mistakes.

void circular_access_safe(unsigned idx) {
array[idx % 10];
}

void circular_access_unsafe(int idx) {
array[idx % 10]; // expected-note {{used in buffer access here}}
}

void masked_idx1(unsigned long long idx, Foo f) {
// Bitwise and operation
Expand Down
Loading