Skip to content

[NVPTX] Do not emit .target debug if only line tables are requested #140146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
superbobry wants to merge 1 commit into from
Closed

[NVPTX] Do not emit .target debug if only line tables are requested #140146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,8 @@ void NVPTXAsmPrinter::emitHeader(Module &M, raw_ostream &O,
switch(CU->getEmissionKind()) {
case DICompileUnit::NoDebug:
case DICompileUnit::DebugDirectivesOnly:
break;
case DICompileUnit::LineTablesOnly:
break;
Copy link
Member

@Artem-B Artem-B May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwblaikie Do I understand it correctly that LineTablesOnly only implies that debug info will be limited to line info only, but it does not say anything about the format of that info. I.e. that it could be either done via debug directives or via DWARF.

If that's the case, then this change is wrong, and the current code is correct.

Copy link
Collaborator

@dwblaikie dwblaikie May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LineTablesOnly unfortunately means /almost/ line tables only - it actually means line tables, /and/ enough of .debug_info to describe inlining.

The DebugDirectivesOnly is means /really/ only the debug directives that generate only the line table (.debug_line (and in DWARFv5, .debug_line_str)).

case DICompileUnit::FullDebug:
HasFullDebugInfo = true;
break;
Expand Down
2 changes: 1 addition & 1 deletion llvm/test/DebugInfo/NVPTX/debug-file-loc.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
;__device__ void bar() {}
;}

; CHECK: .target sm_{{[0-9]+}}, debug
; CHECK: .target sm_{{[0-9]+}}

; CHECK: .visible .func foo()
; CHECK: .loc [[FOO:[0-9]+]] 1 31
Expand Down