[ICP] Use a block with LLVM_DEBUG (NFC) #140387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a block inside LLVM_DEBUG allows us to simplify the code with a single LLVM_DEBUG and remove maybe_unused.
Member
|
@llvm/pr-subscribers-pgo Author: Kazu Hirata (kazutakahirata) ChangesUsing a block inside LLVM_DEBUG allows us to simplify the code with a Full diff: https://github.com/llvm/llvm-project/pull/140387.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp b/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
index 6817be23be5f8..854db0ff6864c 100644
--- a/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
+++ b/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
@@ -858,13 +858,14 @@ bool IndirectCallPromoter::isProfitableToCompareVTables(
auto &Candidate = Candidates[I];
auto &VTableGUIDAndCounts = Candidate.VTableGUIDAndCounts;
- LLVM_DEBUG(dbgs() << " Candidate " << I << " FunctionCount: "
- << Candidate.Count << ", VTableCounts:");
- // Add [[maybe_unused]] since <GUID, Count> are only used by LLVM_DEBUG.
- for ([[maybe_unused]] auto &[GUID, Count] : VTableGUIDAndCounts)
- LLVM_DEBUG(dbgs() << " {" << Symtab->getGlobalVariable(GUID)->getName()
- << ", " << Count << "}");
- LLVM_DEBUG(dbgs() << "\n");
+ LLVM_DEBUG({
+ dbgs() << " Candidate " << I << " FunctionCount: " << Candidate.Count
+ << ", VTableCounts:";
+ for (const auto &[GUID, Count] : VTableGUIDAndCounts)
+ dbgs() << " {" << Symtab->getGlobalVariable(GUID)->getName() << ", "
+ << Count << "}";
+ dbgs() << "\n";
+ });
uint64_t CandidateVTableCount = 0;
|
Member
|
@llvm/pr-subscribers-llvm-transforms Author: Kazu Hirata (kazutakahirata) ChangesUsing a block inside LLVM_DEBUG allows us to simplify the code with a Full diff: https://github.com/llvm/llvm-project/pull/140387.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp b/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
index 6817be23be5f8..854db0ff6864c 100644
--- a/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
+++ b/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
@@ -858,13 +858,14 @@ bool IndirectCallPromoter::isProfitableToCompareVTables(
auto &Candidate = Candidates[I];
auto &VTableGUIDAndCounts = Candidate.VTableGUIDAndCounts;
- LLVM_DEBUG(dbgs() << " Candidate " << I << " FunctionCount: "
- << Candidate.Count << ", VTableCounts:");
- // Add [[maybe_unused]] since <GUID, Count> are only used by LLVM_DEBUG.
- for ([[maybe_unused]] auto &[GUID, Count] : VTableGUIDAndCounts)
- LLVM_DEBUG(dbgs() << " {" << Symtab->getGlobalVariable(GUID)->getName()
- << ", " << Count << "}");
- LLVM_DEBUG(dbgs() << "\n");
+ LLVM_DEBUG({
+ dbgs() << " Candidate " << I << " FunctionCount: " << Candidate.Count
+ << ", VTableCounts:";
+ for (const auto &[GUID, Count] : VTableGUIDAndCounts)
+ dbgs() << " {" << Symtab->getGlobalVariable(GUID)->getName() << ", "
+ << Count << "}";
+ dbgs() << "\n";
+ });
uint64_t CandidateVTableCount = 0;
|
teresajohnson
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a block inside LLVM_DEBUG allows us to simplify the code with a
single LLVM_DEBUG and remove maybe_unused.