Skip to content

Fix typo in IRDL docs #140460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Fix typo in IRDL docs #140460

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d39a9f2
Update IRDLOps.td
noamzaks May 18, 2025
fb0abd7
Merge branch 'main' into irdl-typo
noamzaks May 18, 2025
b342715
Apply suggestion from Mathieu
noamzaks May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/IRDL/IR/IRDLOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ def IRDL_AllOfOp : IRDL_ConstraintOp<"all_of",
```

The above program defines a type `complex` inside the dialect `cmath` that
can has one parameter that must be 32-bit long and a float (in other
can have one parameter that must be 32-bit long and a float (in other
Copy link
Contributor

@math-fehr math-fehr May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
can have one parameter that must be 32-bit long and a float (in other
has one parameter that must be 32-bit long and a float (in other

Actually, I think has would be better than can have here, because the parameter is required. Otherwise, readers might think that it is optional. What do you think?

Copy link
Contributor Author

@noamzaks noamzaks May 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I chose "can have" because it is used in line 600 as well, so I'll change both (since it's not optional)

words, that must be `f32`).
}];

Expand Down