Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 18, 2025

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/140466.diff

1 Files Affected:

  • (modified) lldb/source/Expression/FunctionCaller.cpp (+1-3)
diff --git a/lldb/source/Expression/FunctionCaller.cpp b/lldb/source/Expression/FunctionCaller.cpp
index ddf1e1151bdcf..83cac130ba728 100644
--- a/lldb/source/Expression/FunctionCaller.cpp
+++ b/lldb/source/Expression/FunctionCaller.cpp
@@ -171,10 +171,8 @@ bool FunctionCaller::WriteFunctionArguments(
     m_wrapper_args_addrs.push_back(args_addr_ref);
   } else {
     // Make sure this is an address that we've already handed out.
-    if (find(m_wrapper_args_addrs.begin(), m_wrapper_args_addrs.end(),
-             args_addr_ref) == m_wrapper_args_addrs.end()) {
+    if (!llvm::is_contained(m_wrapper_args_addrs, args_addr_ref))
       return false;
-    }
   }
 
   // TODO: verify fun_addr needs to be a callable address

@kazutakahirata kazutakahirata merged commit 25da043 into llvm:main May 19, 2025
12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_range_llvm_is_contained_lldb branch May 19, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants