Skip to content

Conversation

@snehasish
Copy link

@snehasish snehasish commented May 19, 2025

Part of a larger refactoring with the following goals

  1. Reduce the size of MemProf.h
  2. Avoid including ModuleSummaryIndex just for a couple of types

@llvmbot
Copy link
Member

llvmbot commented May 19, 2025

@llvm/pr-subscribers-pgo

Author: Snehasish Kumar (snehasish)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/140504.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ProfileData/MemProf.h (+16-4)
diff --git a/llvm/include/llvm/ProfileData/MemProf.h b/llvm/include/llvm/ProfileData/MemProf.h
index ce5cd5ee4856b..683193aa42747 100644
--- a/llvm/include/llvm/ProfileData/MemProf.h
+++ b/llvm/include/llvm/ProfileData/MemProf.h
@@ -1,5 +1,18 @@
-#ifndef LLVM_PROFILEDATA_MEMPROF_H_
-#define LLVM_PROFILEDATA_MEMPROF_H_
+//===- MemProf.h - MemProf support ------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file contains common definitions used in the reading and writing of
+// memory profile data.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_PROFILEDATA_MEMPROF_H
+#define LLVM_PROFILEDATA_MEMPROF_H
 
 #include "llvm/ADT/BitVector.h"
 #include "llvm/ADT/MapVector.h"
@@ -844,5 +857,4 @@ struct LineLocation {
 using CallEdgeTy = std::pair<LineLocation, uint64_t>;
 } // namespace memprof
 } // namespace llvm
-
-#endif // LLVM_PROFILEDATA_MEMPROF_H_
+#endif // LLVM_PROFILEDATA_MEMPROF_H

@snehasish snehasish force-pushed the users/snehasish/05-16-_nfc_memprof_add_the_llvm_license_text_and_minor_clean_up branch from 532d85a to 36aeb3a Compare May 19, 2025 22:15
@snehasish snehasish force-pushed the users/snehasish/05-16-_nfc_memprof_move_indexedmemprofdata_to_its_own_header branch from 61b636b to 02c867e Compare May 19, 2025 22:15
Copy link
Author

snehasish commented May 19, 2025

Merge activity

  • May 19, 7:09 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 19, 7:22 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 19, 7:24 PM EDT: @snehasish merged this pull request with Graphite.

@snehasish snehasish force-pushed the users/snehasish/05-16-_nfc_memprof_move_indexedmemprofdata_to_its_own_header branch from 02c867e to 171c89a Compare May 19, 2025 23:19
Base automatically changed from users/snehasish/05-16-_nfc_memprof_move_indexedmemprofdata_to_its_own_header to main May 19, 2025 23:21
@snehasish snehasish force-pushed the users/snehasish/05-16-_nfc_memprof_add_the_llvm_license_text_and_minor_clean_up branch from 36aeb3a to 1b82b50 Compare May 19, 2025 23:22
@snehasish snehasish merged commit c2fd63c into main May 19, 2025
6 of 9 checks passed
@snehasish snehasish deleted the users/snehasish/05-16-_nfc_memprof_add_the_llvm_license_text_and_minor_clean_up branch May 19, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PGO Profile Guided Optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants