Skip to content

[mlir][spirv] Check output of getConstantInt #140568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IgWod-IMG merged 3 commits into from
Jun 4, 2025
Merged

[mlir][spirv] Check output of getConstantInt #140568

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afd991c
[mlir][spirv] Check output of getConstantInt
IgWod-IMG May 19, 2025
7ea6cca
Use emitError
IgWod-IMG May 27, 2025
19d5056
Split check
IgWod-IMG May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,12 +1061,30 @@ LogicalResult spirv::Deserializer::processCooperativeMatrixTypeKHR(
<< operands[2];
}

unsigned rows = getConstantInt(operands[3]).getInt();
unsigned columns = getConstantInt(operands[4]).getInt();
IntegerAttr rowsAttr = getConstantInt(operands[3]);
IntegerAttr columnsAttr = getConstantInt(operands[4]);
IntegerAttr useAttr = getConstantInt(operands[5]);

if (!rowsAttr)
return emitError(unknownLoc, "OpTypeCooperativeMatrixKHR `Rows` references "
"undefined constant <id> ")
<< operands[3];

if (!columnsAttr)
return emitError(unknownLoc, "OpTypeCooperativeMatrixKHR `Columns` "
"references undefined constant <id> ")
<< operands[4];

if (!useAttr)
return emitError(unknownLoc, "OpTypeCooperativeMatrixKHR `Use` references "
"undefined constant <id> ")
<< operands[5];

unsigned rows = rowsAttr.getInt();
unsigned columns = columnsAttr.getInt();

std::optional<spirv::CooperativeMatrixUseKHR> use =
spirv::symbolizeCooperativeMatrixUseKHR(
getConstantInt(operands[5]).getInt());
spirv::symbolizeCooperativeMatrixUseKHR(useAttr.getInt());
if (!use) {
return emitError(
unknownLoc,
Expand Down