Skip to content

[LLVM][IR] Support target extension types in vectors #140630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2025
Merged

[LLVM][IR] Support target extension types in vectors #140630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78a86cf
Support target extension types in vectors
arysef May 19, 2025
9951121
Merge remote-tracking branch 'upstream/main' into dev/arysef/target_i…
arysef May 27, 2025
11cbeee
Merge remote-tracking branch 'upstream/main' into dev/arysef/target_i…
arysef Jun 5, 2025
3324462
add property to opt in to being a valid vector element type
arysef Jun 5, 2025
9ad6926
improve comments, move sized check into target type creation
arysef Jun 6, 2025
56639dc
remove conditional, use only assert
arysef Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/IR/Type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,8 @@ VectorType *VectorType::get(Type *ElementType, ElementCount EC) {

bool VectorType::isValidElementType(Type *ElemTy) {
return ElemTy->isIntegerTy() || ElemTy->isFloatingPointTy() ||
ElemTy->isPointerTy() || ElemTy->getTypeID() == TypedPointerTyID;
ElemTy->isPointerTy() || ElemTy->getTypeID() == TypedPointerTyID ||
(ElemTy->isTargetExtTy() && ElemTy->isSized());
}

//===----------------------------------------------------------------------===//
Expand Down
8 changes: 8 additions & 0 deletions llvm/test/Verifier/target-ext-vector-invalid.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
Copy link
Contributor

@arsenm arsenm Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-disable-output instead of -o /dev/null


; CHECK: invalid vector element type

define void @bad() {
%v = alloca <2 x target("spirv.IntegralConstant")>
ret void
}
Copy link
Contributor

@arsenm arsenm Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline error

11 changes: 11 additions & 0 deletions llvm/test/Verifier/target-ext-vector.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
; RUN: llvm-as -o - %s | llvm-dis | FileCheck %s

; CHECK-LABEL: @vec_ops(
define <2 x target("spirv.Image")> @vec_ops(<2 x target("spirv.Image")> %x) {
%a = alloca <2 x target("spirv.Image")>
store <2 x target("spirv.Image")> %x, ptr %a
%load = load <2 x target("spirv.Image")>, ptr %a
%elt = extractelement <2 x target("spirv.Image")> %load, i64 0
%res = insertelement <2 x target("spirv.Image")> undef, target("spirv.Image") %elt, i64 1
ret <2 x target("spirv.Image")> %res
}