Skip to content

[CGData] Return ArrayRef<std::string> in getNames (NFC) #140675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

[CGData] Return ArrayRef<std::string> in getNames (NFC) #140675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee40f71
[CGData] Return ArrayRef<std::string> in getNames (NFC)
kazutakahirata May 20, 2025
97a4798
Update llvm/lib/CGData/StableFunctionMapRecord.cpp
kazutakahirata May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/CGData/StableFunctionMap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ struct StableFunctionMap {
const HashFuncsMapType &getFunctionMap() const { return HashToFuncs; }

/// Get the NameToId vector for serialization.
const SmallVector<std::string> getNames() const { return IdToName; }
ArrayRef<std::string> getNames() const { return IdToName; }

/// Get an existing ID associated with the given name or create a new ID if it
/// doesn't exist.
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/CGData/StableFunctionMapRecord.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void StableFunctionMapRecord::serialize(raw_ostream &OS,
support::endian::Writer Writer(OS, endianness::little);

// Write Names.
auto &Names = FunctionMap->getNames();
auto Names = FunctionMap->getNames();
uint32_t ByteSize = 4;
Writer.write<uint32_t>(Names.size());
for (auto &Name : Names) {
Expand Down