Skip to content

[mlir] Check for int limits when converting gpu dims #140747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

[mlir] Check for int limits when converting gpu dims #140747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c9885e
[mlir] Check for int limits when converting gpu dims
Max191 May 15, 2025
e4d859f
address comment
Max191 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mlir/lib/Conversion/GPUCommon/IndexIntrinsicsOpLowering.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ struct OpLowering : public ConvertOpToLLVMPattern<Op> {

if (upperBound && intrType != IntrType::None) {
int32_t min = (intrType == IntrType::Dim ? 1 : 0);
int32_t max = *upperBound + (intrType == IntrType::Id ? 0 : 1);
int32_t max = *upperBound == INT_MAX
? *upperBound
: *upperBound + (intrType == IntrType::Id ? 0 : 1);
newOp->setAttr("range", LLVM::ConstantRangeAttr::get(
rewriter.getContext(), 32, min, max));
}
Expand Down
13 changes: 13 additions & 0 deletions mlir/test/Conversion/GPUToROCDL/gpu-to-rocdl.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,3 +763,16 @@ gpu.module @test_module {
gpu.module @test_custom_data_layout attributes {llvm.data_layout = "e"} {

}

// -----

gpu.module @test_module {
// CHECK32-LABEL: func @gpu_dim_int_max_upper_bound()
func.func @gpu_dim_int_max_upper_bound()
-> (index) {

// CHECK32: rocdl.workgroup.dim.x range <i32, 1, 2147483647> : i32
%bDimX = gpu.block_dim x upper_bound 2147483647
func.return %bDimX : index
}
}
Loading