Skip to content

[clang-tidy][NFC] Refactor modernize-pass-by-value check code and tests #140753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

[clang-tidy][NFC] Refactor modernize-pass-by-value check code and tests #140753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c4c04
[clang-tidy][nfc] refactor pass-by-value check tests to use check-fix…
vbvictor May 20, 2025
f3feecc
[clang-tidy][nfc] removed CHECK-MESSAGES-NOT and CHECK-FIXES-NOT
vbvictor May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,8 @@ static bool hasRValueOverload(const CXXConstructorDecl *Ctor,
};

for (const auto *Candidate : Record->ctors()) {
if (IsRValueOverload(Candidate)) {
if (IsRValueOverload(Candidate))
return true;
}
}
return false;
}
Expand Down
2 changes: 0 additions & 2 deletions clang-tools-extra/clang-tidy/modernize/PassByValueCheck.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
#include "../ClangTidyCheck.h"
#include "../utils/IncludeInserter.h"

#include <memory>

namespace clang::tidy::modernize {

class PassByValueCheck : public ClangTidyCheck {
Expand Down
11 changes: 0 additions & 11 deletions clang-tools-extra/test/clang-tidy/checkers/modernize/pass-by-value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,16 @@ struct A {
Movable GlobalObj;
struct B {
B(const Movable &M) : M(GlobalObj) {}
// CHECK-FIXES: B(const Movable &M) : M(GlobalObj) {}
Movable M;
};

// Test that a parameter with more than one reference to it won't be changed.
struct C {
// Tests extra-reference in body.
C(const Movable &M) : M(M) { this->i = M.a; }
// CHECK-FIXES: C(const Movable &M) : M(M) { this->i = M.a; }

// Tests extra-reference in init-list.
C(const Movable &M, int) : M(M), i(M.a) {}
// CHECK-FIXES: C(const Movable &M, int) : M(M), i(M.a) {}
Movable M;
int i;
};
Expand All @@ -70,7 +67,6 @@ struct E {
// Test with object that can't be moved.
struct F {
F(const NotMovable &NM) : NM(NM) {}
// CHECK-FIXES: F(const NotMovable &NM) : NM(NM) {}
NotMovable NM;
};

Expand Down Expand Up @@ -112,7 +108,6 @@ struct I {
// Test that templates aren't modified.
template <typename T> struct J {
J(const T &M) : M(M) {}
// CHECK-FIXES: J(const T &M) : M(M) {}
T M;
};
J<Movable> j1(Movable());
Expand All @@ -129,13 +124,11 @@ struct MovableTemplateT
template <class T>
struct J2 {
J2(const MovableTemplateT<T>& A);
// CHECK-FIXES: J2(const MovableTemplateT<T>& A);
MovableTemplateT<T> M;
};

template <class T>
J2<T>::J2(const MovableTemplateT<T>& A) : M(A) {}
// CHECK-FIXES: J2<T>::J2(const MovableTemplateT<T>& A) : M(A) {}
J2<int> j3(MovableTemplateT<int>{});

struct K_Movable {
Expand Down Expand Up @@ -182,7 +175,6 @@ struct O {
// Test with a const-value parameter.
struct P {
P(const Movable M) : M(M) {}
// CHECK-FIXES: P(const Movable M) : M(M) {}
Movable M;
};

Expand Down Expand Up @@ -215,7 +207,6 @@ struct R {
// Test with rvalue parameter.
struct S {
S(Movable &&M) : M(M) {}
// CHECK-FIXES: S(Movable &&M) : M(M) {}
Movable M;
};

Expand All @@ -225,13 +216,11 @@ template <typename T, int N> struct array { T A[N]; };
// cause problems with performance-move-const-arg, as it will revert it.
struct T {
T(array<int, 10> a) : a_(a) {}
// CHECK-FIXES: T(array<int, 10> a) : a_(a) {}
array<int, 10> a_;
};

struct U {
U(const POD &M) : M(M) {}
// CHECK-FIXES: U(const POD &M) : M(M) {}
POD M;
};

Expand Down
Loading