Skip to content

[lldb-dap] Avoid double 'new' events for dyld on Darwin #140810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

[lldb-dap] Avoid double 'new' events for dyld on Darwin #140810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions lldb/tools/lldb-dap/DAP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,22 +1292,17 @@ void DAP::EventThread() {

llvm::StringRef reason;
bool id_only = false;
if (event_mask & lldb::SBTarget::eBroadcastBitModulesLoaded) {
modules.insert(module_id);
reason = "new";
} else {
// If this is a module we've never told the client about, don't
// send an event.
if (!modules.contains(module_id))
continue;

if (modules.contains(module_id)) {
if (event_mask & lldb::SBTarget::eBroadcastBitModulesUnloaded) {
modules.erase(module_id);
reason = "removed";
id_only = true;
} else {
reason = "changed";
}
} else {
modules.insert(module_id);
reason = "new";
}

llvm::json::Object body;
Expand Down
Loading