Skip to content

[ARM] Remove unused class member in ARMConstantIslandPass #141093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
statham-arm merged 1 commit into from
May 27, 2025
Merged

[ARM] Remove unused class member in ARMConstantIslandPass #141093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ namespace {
/// base address.
DenseMap<int, int> JumpTableUserIndices;

// Maps a MachineBasicBlock to the number of jump tables entries.
DenseMap<const MachineBasicBlock *, int> BlockJumpTableRefCount;

/// ImmBranch - One per immediate branch, keeping the machine instruction
/// pointer, conditional or unconditional, the max displacement,
/// and (if isCond is true) the corresponding unconditional branch
Expand Down Expand Up @@ -523,7 +520,6 @@ bool ARMConstantIslands::runOnMachineFunction(MachineFunction &mf) {
CPEntries.clear();
JumpTableEntryIndices.clear();
JumpTableUserIndices.clear();
BlockJumpTableRefCount.clear();
ImmBranches.clear();
PushPopMIs.clear();
T2JumpTables.clear();
Expand Down Expand Up @@ -736,14 +732,6 @@ Align ARMConstantIslands::getCPEAlign(const MachineInstr *CPEMI) {
return MCP->getConstants()[CPI].getAlign();
}

// Exception landing pads, blocks that has their adress taken, and function
// entry blocks will always be (potential) indirect jump targets, regardless of
// whether they are referenced by or not by jump tables.
static bool isAlwaysIndirectTarget(const MachineBasicBlock &MBB) {
return MBB.isEHPad() || MBB.hasAddressTaken() ||
&MBB == &MBB.getParent()->front();
}

/// scanFunctionJumpTables - Do a scan of the function, building up
/// information about the sizes of each block and the locations of all
/// the jump tables.
Expand All @@ -754,20 +742,6 @@ void ARMConstantIslands::scanFunctionJumpTables() {
(I.getOpcode() == ARM::t2BR_JT || I.getOpcode() == ARM::tBR_JTr))
T2JumpTables.push_back(&I);
}

if (!MF->getInfo<ARMFunctionInfo>()->branchTargetEnforcement())
return;

if (const MachineJumpTableInfo *JTI = MF->getJumpTableInfo())
for (const MachineJumpTableEntry &JTE : JTI->getJumpTables())
for (const MachineBasicBlock *MBB : JTE.MBBs) {
if (isAlwaysIndirectTarget(*MBB))
// Set the reference count essentially to infinity, it will never
// reach zero and the BTI Instruction will never be removed.
BlockJumpTableRefCount[MBB] = std::numeric_limits<int>::max();
else
++BlockJumpTableRefCount[MBB];
}
}

/// initializeFunctionInfo - Do the initial scan of the function, building up
Expand Down