Skip to content

[APInt] APInt::clearBitsSlowCase - fix cut+paste typo when merging lo/himasks #141108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

[APInt] APInt::clearBitsSlowCase - fix cut+paste typo when merging lo/himasks #141108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Support/APInt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,9 @@ void APInt::clearBitsSlowCase(unsigned LoBit, unsigned HiBit) {
// Create a high mask with ones above HiBit.
uint64_t HiMask = ~(WORDTYPE_MAX >> (APINT_BITS_PER_WORD - HiShiftAmt));
// If LoWord and HiWord are equal, then we combine the masks. Otherwise,
// set the bits in HiWord.
// clear the bits in HiWord.
if (HiWord == LoWord)
LoMask &= HiMask;
LoMask |= HiMask;
else
U.pVal[HiWord] &= HiMask;
}
Expand Down
9 changes: 9 additions & 0 deletions llvm/unittests/ADT/APIntTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2556,6 +2556,15 @@ TEST(APIntTest, clearBits) {
EXPECT_EQ(6u, i256.countl_one());
EXPECT_EQ(16u, i256.popcount());

APInt i299 = APInt::getAllOnes(299);
i299.clearBits(240, 250);
EXPECT_EQ(240u, i299.countr_one());
EXPECT_EQ(0u, i299.countr_zero());
EXPECT_EQ(299u, i299.getActiveBits());
EXPECT_EQ(0u, i299.countl_zero());
EXPECT_EQ(49u, i299.countl_one());
EXPECT_EQ(289u, i299.popcount());

APInt i311 = APInt::getAllOnes(311);
i311.clearBits(33, 99);
EXPECT_EQ(33u, i311.countr_one());
Expand Down