Skip to content

[Support] Use std::map::try_emplace (NFC) #141374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025
Merged

[Support] Use std::map::try_emplace (NFC) #141374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/lib/Support/DAGDeltaAlgorithm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ DAGDeltaAlgorithmImpl::DAGDeltaAlgorithmImpl(
const std::vector<edge_ty> &Dependencies)
: DDA(DDA) {
for (change_ty Change : Changes) {
Predecessors.insert(std::make_pair(Change, std::vector<change_ty>()));
Successors.insert(std::make_pair(Change, std::vector<change_ty>()));
Predecessors.try_emplace(Change);
Successors.try_emplace(Change);
}
for (const edge_ty &Dep : Dependencies) {
Predecessors[Dep.second].push_back(Dep.first);
Expand Down Expand Up @@ -210,7 +210,7 @@ DAGDeltaAlgorithmImpl::DAGDeltaAlgorithmImpl(

// Invert to form the predecessor closure map.
for (change_ty Change : Changes)
PredClosure.insert(std::make_pair(Change, std::set<change_ty>()));
PredClosure.try_emplace(Change);
for (change_ty Change : Changes)
for (succ_closure_iterator_ty it2 = succ_closure_begin(Change),
ie2 = succ_closure_end(Change);
Expand Down